Issue 71503004: Further improve Math.sin/cos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71503004: Further improve Math.sin/cos. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Further improve Math.sin/cos. R=jkummerow@chromium.org

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -18 lines)			Patch
	M	src/math.js	View	1	3 chunks	+10 lines, -18 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 1 month ago (2013-11-18 13:53:46 UTC) #2

LGTM, except for a nit about the CL description: remove the "BUG=" or you'll
have to add "LOG=N".

Go ahead and do the platform ports :-P

https://codereview.chromium.org/71503004/diff/40001/src/math.js
File src/math.js (right):

https://codereview.chromium.org/71503004/diff/40001/src/math.js#newcode252
src/math.js:252: if (%_IsMinusZero(multiple)) return -0;
Why this change? "return multiple" might be (ever so slightly) faster.

Expand Messages | Collapse Messages