Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: Source/modules/serviceworkers/ExtendableEvent.cpp

Issue 715013003: ExtendableEvent and InstallEvent should have an EventConstructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: basic layout test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.h ('k') | Source/modules/serviceworkers/ExtendableEvent.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ExtendableEvent.cpp
diff --git a/Source/modules/serviceworkers/ExtendableEvent.cpp b/Source/modules/serviceworkers/ExtendableEvent.cpp
index 0d4db1534c5ebbde7ed1e96cd282ff5178eed7df..05e846c7f360e21d56393c10ef167d126b3ec4f9 100644
--- a/Source/modules/serviceworkers/ExtendableEvent.cpp
+++ b/Source/modules/serviceworkers/ExtendableEvent.cpp
@@ -41,7 +41,12 @@ PassRefPtrWillBeRawPtr<ExtendableEvent> ExtendableEvent::create()
return adoptRefWillBeNoop(new ExtendableEvent());
}
-PassRefPtrWillBeRawPtr<ExtendableEvent> ExtendableEvent::create(const AtomicString& type, const EventInit& eventInit, WaitUntilObserver* observer)
+PassRefPtrWillBeRawPtr<ExtendableEvent> ExtendableEvent::create(const AtomicString& type, const ExtendableEventInit& eventInit)
+{
+ return adoptRefWillBeNoop(new ExtendableEvent(type, eventInit));
+}
+
+PassRefPtrWillBeRawPtr<ExtendableEvent> ExtendableEvent::create(const AtomicString& type, const ExtendableEventInit& eventInit, WaitUntilObserver* observer)
{
return adoptRefWillBeNoop(new ExtendableEvent(type, eventInit, observer));
}
@@ -52,14 +57,20 @@ ExtendableEvent::~ExtendableEvent()
void ExtendableEvent::waitUntil(ScriptState* scriptState, const ScriptValue& value)
{
- m_observer->waitUntil(scriptState, value);
+ if (m_observer)
+ m_observer->waitUntil(scriptState, value);
}
ExtendableEvent::ExtendableEvent()
{
}
-ExtendableEvent::ExtendableEvent(const AtomicString& type, const EventInit& initializer, WaitUntilObserver* observer)
+ExtendableEvent::ExtendableEvent(const AtomicString& type, const ExtendableEventInit& initializer)
+ : Event(type, initializer)
+{
+}
+
+ExtendableEvent::ExtendableEvent(const AtomicString& type, const ExtendableEventInit& initializer, WaitUntilObserver* observer)
: Event(type, initializer)
, m_observer(observer)
{
« no previous file with comments | « Source/modules/serviceworkers/ExtendableEvent.h ('k') | Source/modules/serviceworkers/ExtendableEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698