Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: Source/modules/serviceworkers/ExtendableEvent.h

Issue 715013003: ExtendableEvent and InstallEvent should have an EventConstructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: basic layout test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ExtendableEvent.h
diff --git a/Source/modules/serviceworkers/ExtendableEvent.h b/Source/modules/serviceworkers/ExtendableEvent.h
index 98282ccbaf61f51db56b38d62ffac07071963cb0..8ed7c8daaf368709d89e4481c4addc65da522186 100644
--- a/Source/modules/serviceworkers/ExtendableEvent.h
+++ b/Source/modules/serviceworkers/ExtendableEvent.h
@@ -38,11 +38,14 @@ namespace blink {
class WaitUntilObserver;
+using ExtendableEventInit = EventInit;
+
class ExtendableEvent : public Event {
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<ExtendableEvent> create();
- static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& type, const EventInit&, WaitUntilObserver*);
+ static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& type, const ExtendableEventInit&);
+ static PassRefPtrWillBeRawPtr<ExtendableEvent> create(const AtomicString& type, const ExtendableEventInit&, WaitUntilObserver*);
virtual ~ExtendableEvent();
@@ -53,7 +56,8 @@ public:
protected:
ExtendableEvent();
- ExtendableEvent(const AtomicString& type, const EventInit&, WaitUntilObserver*);
+ ExtendableEvent(const AtomicString& type, const ExtendableEventInit&);
+ ExtendableEvent(const AtomicString& type, const ExtendableEventInit&, WaitUntilObserver*);
PersistentWillBeMember<WaitUntilObserver> m_observer;
};
« no previous file with comments | « LayoutTests/http/tests/serviceworker/resources/interfaces-worker.js ('k') | Source/modules/serviceworkers/ExtendableEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698