ExtendableEvent and InstallEvent should have an EventConstructor

ExtendableEvent and InstallEvent should have an EventConstructor

This brings the events in line with the Service Worker specification.

This allows us to implement events deriving from ExtendableEvent
(most notably Push, NotificationClick and NotificationError) according
to their specifications as well.

BUG=420896
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185365

[Peter Beverloo, 2014-11-12 17:29:13]

peter@chromium.org changed reviewers:
+ horo@chromium.org

[Peter Beverloo, 2014-11-12 17:29:13]

+horo for Service Workers.

The install event does not have the "activeWorker" property yet, so I omitted
that.

[falken, 2014-11-13 01:36:09]

falken@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2014-11-13 01:36:10]

Drive-by comment: you can use BUG=420896

A test would also be good.

[horo, 2014-11-13 03:02:27]

Looks good.
But please add LayoutTest for creating InstallEvent as falken@ is saying.

[Peter Beverloo, 2014-11-13 12:01:52]

On 2014/11/13 03:02:27, horo wrote:
> Looks good.
> But please add LayoutTest for creating InstallEvent as falken@ is saying.

I added two constructor asserts as part of interfaces-worker.js (and verified
that they fail before the patch). Other tests already verify their
functionality. I also mentioned the BUG in the description (thanks!)

WDYT?

[Peter Beverloo, 2014-11-13 14:56:52]

peter@chromium.org changed reviewers:
+ michaeln@chromium.org

[Peter Beverloo, 2014-11-13 14:56:53]

+michaeln for review.

[horo, 2014-11-14 03:48:25]

lgtm

[Peter Beverloo, 2014-11-14 09:23:18]

peter@chromium.org changed reviewers:
+ mkwst@chromium.org

[Peter Beverloo, 2014-11-14 09:23:19]

Thanks!

+mkwst for Source/web/ stamp.

[Mike West, 2014-11-14 10:15:42]

Source/web LGTM.

[Peter Beverloo, 2014-11-14 10:24:41]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2014-11-14 10:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/715013003/20001

[commit-bot: I haz the power, 2014-11-14 11:28:16]

Committed patchset #2 (id:20001) as 185365