Add protobuffer and model type for syncing custom search engines. Includes all boilerplate helper...

Add protobuffer and model type for syncing custom search engines. Includes all boilerplate helpers, unittests, and python server updates.

BUG=15548
TEST=None. All sync unit and integration test should still run and pass.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90772

[SteveT, 2011-06-17 19:05:47]

Hi Nicolas,

Here's the first patch adding the protobuffer for custom search engines... plus
all the boilerplate additions around adding new data types. Let me know if I am
missing anything!

Thanks,


Steve

[Nicolas Zea, 2011-06-20 20:10:54]

LGTM now that the usage count is being removed. Note that until the server side
is updated to reflect the new type, you can only do testing against the python
test server (integration tests use the test server too, so that's fine).

http://codereview.chromium.org/7150023/diff/6015/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/7150023/diff/6015/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.h:260: const sync_pb::SearchEngineSpecifics&
GetSearchEngineSpecifics() const;
Since you're using the new SyncAPI this is not necessary.

[SteveT, 2011-06-22 14:02:52]

Addressed your comment and also removed the entry for usage_count. I owe sky@ a
CL where we remove usage_count from TemplateURL since it's not really being used
anywhere.

Thanks!

http://codereview.chromium.org/7150023/diff/6015/chrome/browser/sync/engine/s...
File chrome/browser/sync/engine/syncapi.h (right):

http://codereview.chromium.org/7150023/diff/6015/chrome/browser/sync/engine/s...
chrome/browser/sync/engine/syncapi.h:260: const sync_pb::SearchEngineSpecifics&
GetSearchEngineSpecifics() const;
On 2011/06/20 20:10:54, nzea wrote:
> Since you're using the new SyncAPI this is not necessary.

Ah that's right. This is the BaseNode which I no longer have to worry about.
Removed this and the forward declaration above.

[SteveT, 2011-06-22 14:12:36]

Hi Andy,

Could take a quick look at net/tools/testserver/chromiumserver.py as you're an
owner of this directory?

Thanks!


Steve

[hendrickson_a, 2011-06-25 04:22:53]

Hi Steve,

Could you pick another person to review as an owner?

I'm on vacation and won't be back until July 6th.

Andy

On 2011/06/22 14:12:36, SteveT wrote:
> Hi Andy,
> 
> Could take a quick look at net/tools/testserver/chromiumserver.py as you're an
> owner of this directory?
> 
> Thanks!
> 
> 
> Steve

[SteveT, 2011-06-27 13:29:02]

R-Andy
R+Gavin

Hi Gavin,

Could you take a look at net/tools/testserver/chromiumsync.py, please?

Thanks!


Steve

[SteveT, 2011-06-28 13:28:45]

On 2011/06/27 13:29:02, SteveT wrote:
> R-Andy
> R+Gavin
> 
> Hi Gavin,
> 
> Could you take a look at net/tools/testserver/chromiumsync.py, please?
> 
> Thanks!
> 
> 
> Steve

Ping.

[gavinp, 2011-06-28 13:52:19]

On 2011/06/28 13:28:45, SteveT wrote:
> On 2011/06/27 13:29:02, SteveT wrote:
> > R-Andy
> > R+Gavin
> > 
> > Hi Gavin,
> > 
> > Could you take a look at net/tools/testserver/chromiumsync.py, please?
> > 
> > Thanks!
> > 
> > 
> > Steve
> 
> Ping.

LGTM!  Sorry about all the delays you ran into with net approval.