Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(77)

Issue 7150023: Add protobuffer and model type for syncing custom search engines. Includes all boilerplate helper... (Closed)

Created:
7 years, 9 months ago by SteveT
Modified:
7 years, 8 months ago
Reviewers:
gavinp, Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), PaweĊ‚ Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Add protobuffer and model type for syncing custom search engines. Includes all boilerplate helpers, unittests, and python server updates. BUG=15548 TEST=None. All sync unit and integration test should still run and pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90772

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -4 lines) Patch
M chrome/browser/sync/glue/data_type_manager_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/protocol/nigori_specifics.proto View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 3 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions_unittest.cc View 1 4 chunks +7 lines, -1 line 0 comments Download
A chrome/browser/sync/protocol/search_engine_specifics.proto View 1 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/browser/sync/protocol/sync_proto.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 11 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/nigori_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/util/cryptographer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/testserver/chromiumsync.py View 1 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
SteveT
Hi Nicolas, Here's the first patch adding the protobuffer for custom search engines... plus all ...
7 years, 9 months ago (2011-06-17 19:05:47 UTC) #1
Nicolas Zea
LGTM now that the usage count is being removed. Note that until the server side ...
7 years, 9 months ago (2011-06-20 20:10:54 UTC) #2
SteveT
Addressed your comment and also removed the entry for usage_count. I owe sky@ a CL ...
7 years, 9 months ago (2011-06-22 14:02:52 UTC) #3
SteveT
Hi Andy, Could take a quick look at net/tools/testserver/chromiumserver.py as you're an owner of this ...
7 years, 9 months ago (2011-06-22 14:12:36 UTC) #4
hendrickson_a
Hi Steve, Could you pick another person to review as an owner? I'm on vacation ...
7 years, 8 months ago (2011-06-25 04:22:53 UTC) #5
SteveT
R-Andy R+Gavin Hi Gavin, Could you take a look at net/tools/testserver/chromiumsync.py, please? Thanks! Steve
7 years, 8 months ago (2011-06-27 13:29:02 UTC) #6
SteveT
On 2011/06/27 13:29:02, SteveT wrote: > R-Andy > R+Gavin > > Hi Gavin, > > ...
7 years, 8 months ago (2011-06-28 13:28:45 UTC) #7
gavinp
7 years, 8 months ago (2011-06-28 13:52:19 UTC) #8
On 2011/06/28 13:28:45, SteveT wrote:
> On 2011/06/27 13:29:02, SteveT wrote:
> > R-Andy
> > R+Gavin
> > 
> > Hi Gavin,
> > 
> > Could you take a look at net/tools/testserver/chromiumsync.py, please?
> > 
> > Thanks!
> > 
> > 
> > Steve
> 
> Ping.

LGTM!  Sorry about all the delays you ran into with net approval.

Powered by Google App Engine
This is Rietveld 408576698