Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 714943002: Move arm-nacl DL description string setting from ctor to setABI. (Closed)

Created:
6 years, 1 month ago by jvoung (off chromium)
Modified:
6 years, 1 month ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-clang.git@merge_35
Visibility:
Public.

Description

Move arm-nacl DL description string setting from ctor to setABI. ARMTargetInfo sets the description string from setABI and not the ctor, so don't do that under the NaClTargetInfo<ARM...> ctor. Otherwise, the NaClTargetInfo<ARM...> ctor will set the description string, then CreateTargetInfo will call setABI() and replace the description string with another one. Move the arm-nacl setting to one place (setABI). Change the existing test to pass "-target-abi aapcs-linux", like what the driver would normally do for NaCl to test this. Also fix up the target-data test to account for the f80 localmods. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3930 R=dschuff@chromium.org Committed: ea86293b0aae2ab43e317256fe042225209de6a0

Patch Set 1 #

Patch Set 2 : fix f80 too #

Total comments: 2

Patch Set 3 : add localmod markers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M lib/Basic/Targets.cpp View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M test/CodeGen/target-data.c View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years, 1 month ago (2014-11-11 17:25:51 UTC) #2
Derek Schuff
lgtm https://codereview.chromium.org/714943002/diff/20001/lib/Basic/Targets.cpp File lib/Basic/Targets.cpp (right): https://codereview.chromium.org/714943002/diff/20001/lib/Basic/Targets.cpp#newcode661 lib/Basic/Targets.cpp:661: // Handled in ARM's setABI(). I guess if ...
6 years, 1 month ago (2014-11-11 17:59:30 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/714943002/diff/20001/lib/Basic/Targets.cpp File lib/Basic/Targets.cpp (right): https://codereview.chromium.org/714943002/diff/20001/lib/Basic/Targets.cpp#newcode661 lib/Basic/Targets.cpp:661: // Handled in ARM's setABI(). On 2014/11/11 17:59:30, Derek ...
6 years, 1 month ago (2014-11-11 18:23:49 UTC) #4
jvoung (off chromium)
6 years, 1 month ago (2014-11-11 18:27:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ea86293b0aae2ab43e317256fe042225209de6a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698