Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: lib/Basic/Targets.cpp

Issue 714943002: Move arm-nacl DL description string setting from ctor to setABI. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-clang.git@merge_35
Patch Set: add localmod markers Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/CodeGen/target-data.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Basic/Targets.cpp
diff --git a/lib/Basic/Targets.cpp b/lib/Basic/Targets.cpp
index 9759c8741dcfcca714baed373b18efe5f687f793..fd5c08408d114042d6b8d7fadfa3a121e90ae464 100644
--- a/lib/Basic/Targets.cpp
+++ b/lib/Basic/Targets.cpp
@@ -658,7 +658,8 @@ public:
// RegParmMax is inherited from the underlying architecture
this->LongDoubleFormat = &llvm::APFloat::IEEEdouble;
if (Triple.getArch() == llvm::Triple::arm) {
- this->DescriptionString = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S128";
+ // @LOCALMOD
+ // Handled in ARM's setABI().
} else if (Triple.getArch() == llvm::Triple::x86) {
this->DescriptionString = "e-m:e-p:32:32-i64:64-f80:32-n8:16:32-S128";
} else if (Triple.getArch() == llvm::Triple::x86_64) {
@@ -3587,7 +3588,12 @@ class ARMTargetInfo : public TargetInfo {
DescriptionString = BigEndian ?
"E-m:o-p:32:32-i64:64-v128:64:128-n32-S64" :
"e-m:o-p:32:32-i64:64-v128:64:128-n32-S64";
- else
+ // @LOCALMOD-BEGIN
+ else if (T.isOSNaCl()) {
+ assert(!BigEndian && "NaCl on ARM does not support big endian");
+ DescriptionString = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S128";
+ } else
+ // @LOCALMOD-END
DescriptionString = BigEndian ?
"E-m:e-p:32:32-i64:64-v128:64:128-n32-S64" :
"e-m:e-p:32:32-i64:64-v128:64:128-n32-S64";
« no previous file with comments | « no previous file | test/CodeGen/target-data.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698