Chromium Code Reviews

Issue 714933002: Set relayoutChildren to 'true' only if size change happens in Table (Closed)

Created:
6 years, 1 month ago by rtakacs
Modified:
6 years, 1 month ago
Reviewers:
leviw_travelin_and_unemployed
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Set relayoutChildren to 'true' only if size change happens in Table This patch passes 'true' value for layoutPositionedObjects() in case of size change. It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185144

Patch Set 1 #

Patch Set 2 : wrong patch #

Unified diffs Side-by-side diffs Stats (+128 lines, -98 lines)
M Source/core/frame/FrameView.cpp View 3 chunks +16 lines, -9 lines 0 comments
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 4 chunks +15 lines, -7 lines 0 comments
M Source/core/rendering/RenderLayer.h View 1 chunk +1 line, -5 lines 0 comments
M Source/core/rendering/RenderLayer.cpp View 5 chunks +8 lines, -8 lines 0 comments
M Source/core/rendering/RenderLayerClipper.cpp View 1 chunk +2 lines, -2 lines 0 comments
M Source/core/rendering/RenderLayerScrollableArea.cpp View 7 chunks +16 lines, -9 lines 0 comments
M Source/core/rendering/RenderTreeAsText.cpp View 1 chunk +3 lines, -3 lines 0 comments
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 5 chunks +12 lines, -8 lines 0 comments
M Source/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/compositing/CompositingLayerAssigner.h View 1 chunk +1 line, -1 line 0 comments
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 6 chunks +9 lines, -8 lines 0 comments
M Source/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 4 chunks +11 lines, -9 lines 0 comments
M Source/core/rendering/compositing/GraphicsLayerUpdater.cpp View 2 chunks +9 lines, -11 lines 0 comments
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 5 chunks +14 lines, -10 lines 0 comments
M Source/core/testing/Internals.cpp View 2 chunks +8 lines, -5 lines 0 comments

Messages

Total messages: 6 (2 generated)
rtakacs
6 years, 1 month ago (2014-11-11 16:57:54 UTC) #2
leviw_travelin_and_unemployed
LGTM.
6 years, 1 month ago (2014-11-11 19:48:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714933002/1
6 years, 1 month ago (2014-11-11 19:49:36 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 20:38:27 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185144

Powered by Google App Engine