chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java - Issue 714643002: Pause EME player whose external surface is stolen by another player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

Issue 714643002: Pause EME player whose external surface is stolen by another player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reuse Java_ExternalVideoSurfaceContainer_destroy() and OnMediaInterrupted() Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/native/external_video_surface_container_impl.h ('K') | « android_webview/native/external_video_surface_container_impl.cc ('k') | content/browser/media/android/browser_media_player_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

index 2769be9f44019003aee374162b94b9c984b91cee..7f2ca38269551ac2679fc8d695ebf0662beed7a5 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

@@ -133,6 +133,14 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {

}

/**

+ * Returns id of player currently using the external video surface.

+ */

+ @CalledByNative

+ protected int getCurrentPlayerId() {

+ return mPlayerId;

+ }

+ /**

* Called when a media player wants to release an external video surface.

* @param playerId The ID of the media player.

@@ -145,6 +153,9 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {

mPlayerId = INVALID_PLAYER_ID;

}

+ /**

+ * Called when a media player wants to release current external video surface.

+ */

@CalledByNative

protected void destroy() {

releaseExternalVideoSurface(mPlayerId);