android_webview/native/external_video_surface_container_impl.h - Issue 714643002: Pause EME player whose external surface is stolen by another player

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/external_video_surface_container_impl.h

Issue 714643002: Pause EME player whose external surface is stolen by another player (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reuse Java_ExternalVideoSurfaceContainer_destroy() and OnMediaInterrupted() Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java ('K') | « android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java ('k') | android_webview/native/external_video_surface_container_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/external_video_surface_container_impl.h

diff --git a/android_webview/native/external_video_surface_container_impl.h b/android_webview/native/external_video_surface_container_impl.h

index 97d233408a10b19627ae0fc2a8e9279aa7f2984a..bb1985fb5685731f655525329062cbf5bc9111c0 100644

--- a/android_webview/native/external_video_surface_container_impl.h

+++ b/android_webview/native/external_video_surface_container_impl.h

@@ -27,7 +27,9 @@ class ExternalVideoSurfaceContainerImpl

int player_id,

const SurfaceCreatedCB& surface_created_cb,

const SurfaceDestroyedCB& surface_destroyed_cb) override;

+ virtual int GetCurrentPlayerId() override;

virtual void ReleaseExternalVideoSurface(int player_id) override;

+ virtual void ReleaseCurrentExternalVideoSurface() override;

boliu 2014/12/04 23:33:26 Is this always the same as ReleaseExternalVideoSur

Hugo Holgersson 2014/12/08 16:41:08 Yes. That is true. Actually, ReleaseCurrentExterna

virtual void OnFrameInfoUpdated() override;

virtual void OnExternalVideoSurfacePositionChanged(

int player_id, const gfx::RectF& rect) override;