Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 714633002: Fix SkTime::GetDateTime Posix implementation, add unit test. (Closed)

Created:
6 years, 1 month ago by hal.canary
Modified:
6 years, 1 month ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix SkTime::GetDateTime Posix implementation, add unit test. The year was off by 1900 Committed: https://skia.googlesource.com/skia/+/8e74b1565c5573a0be40060cebbc112fc156f26d

Patch Set 1 : compile errors #

Patch Set 2 : limit the year check in the test to the next 50 years #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkTime_Unix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/Time.cpp View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hal.canary
PTAL
6 years, 1 month ago (2014-11-10 14:36:13 UTC) #2
caryclark
On 2014/11/10 14:36:13, Hal Canary wrote: > PTAL Could you run the trybots to exercise ...
6 years, 1 month ago (2014-11-10 14:52:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714633002/20001
6 years, 1 month ago (2014-11-10 14:57:12 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-10 14:57:13 UTC) #6
caryclark
lgtm
6 years, 1 month ago (2014-11-10 17:00:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714633002/40001
6 years, 1 month ago (2014-11-10 17:13:07 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 17:20:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/8e74b1565c5573a0be40060cebbc112fc156f26d

Powered by Google App Engine
This is Rietveld 408576698