src/ports/SkTime_Unix.cpp - Issue 714633002: Fix SkTime::GetDateTime Posix implementation, add unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkTime_Unix.cpp

Issue 714633002: Fix SkTime::GetDateTime Posix implementation, add unit test. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: limit the year check in the test to the next 50 years Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkTime_Unix.cpp

diff --git a/src/ports/SkTime_Unix.cpp b/src/ports/SkTime_Unix.cpp

index f519a69d07c2843a60427ea385a5d79b11dd765c..6e305a16f6eb8073e393e1d5d8629826035daaab 100644

--- a/src/ports/SkTime_Unix.cpp

+++ b/src/ports/SkTime_Unix.cpp

@@ -20,8 +20,8 @@ void SkTime::GetDateTime(DateTime* dt)

time(&m_time);

struct tm* tstruct;

tstruct = localtime(&m_time);

- dt->fYear = tstruct->tm_year;

+ // http://pubs.opengroup.org/onlinepubs/009695399/basedefs/time.h.html

+ dt->fYear = tstruct->tm_year + 1900;

dt->fMonth = SkToU8(tstruct->tm_mon + 1);

dt->fDayOfWeek = SkToU8(tstruct->tm_wday);

dt->fDay = SkToU8(tstruct->tm_mday);

« no previous file with comments | « gyp/tests.gypi ('k') | tests/Time.cpp » ('j') | no next file with comments »