Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sky/viewer/cc/sky_viewer_cc_export.h

Issue 714393002: Remove support for MSVC (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sky/engine/wtf/Assertions.h ('K') | « sky/engine/wtf/text/WTFString.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/cc/sky_viewer_cc_export.h
diff --git a/sky/viewer/cc/sky_viewer_cc_export.h b/sky/viewer/cc/sky_viewer_cc_export.h
index bf2a13803720fd26b90901ef0bfba0185415d779..6719cbd6504836845a7724910d2d2acc2c3a3946 100644
--- a/sky/viewer/cc/sky_viewer_cc_export.h
+++ b/sky/viewer/cc/sky_viewer_cc_export.h
@@ -6,21 +6,12 @@
#define SKY_VIEWER_CC_SKY_VIEWER_CC_EXPORT_H_
#if defined(COMPONENT_BUILD)
-#if defined(WIN32)
#if defined(SKY_VIEWER_CC_IMPLEMENTATION)
-#define SKY_VIEWER_CC_EXPORT __declspec(dllexport)
-#else
-#define SKY_VIEWER_CC_EXPORT __declspec(dllimport)
-#endif // defined(SKY_VIEWER_CC_IMPLEMENTATION)
-
-#else // defined(WIN32)
-#if defined(SKY_VIEWER_CC_IMPLEMENTATION)
#define SKY_VIEWER_CC_EXPORT __attribute__((visibility("default")))
abarth-chromium 2014/11/12 00:28:14 You can remove all this FOO_EXPORT stuff. It's fo
#else
#define SKY_VIEWER_CC_EXPORT
#endif
-#endif
#else // defined(COMPONENT_BUILD)
#define SKY_VIEWER_CC_EXPORT
« sky/engine/wtf/Assertions.h ('K') | « sky/engine/wtf/text/WTFString.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698