Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: tools/perf/benchmarks/scirra.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/scirra.py
diff --git a/tools/perf/benchmarks/scirra.py b/tools/perf/benchmarks/scirra.py
index 4b7d05a90464dcef82f2784f801e4ea67e45eaff..2603007b221bf3eae3adb1af3da818149b30f956 100644
--- a/tools/perf/benchmarks/scirra.py
+++ b/tools/perf/benchmarks/scirra.py
@@ -10,18 +10,18 @@ represented onscreen when the animation reaches the 30 FPS threshold.
import os
+from measurements import PageTestMeasurement
from telemetry import benchmark
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import scalar
-class _ScirraMeasurement(page_test.PageTest):
+class _ScirraMeasurement(PageTestMeasurement):
def WillNavigateToPage(self, page, tab):
page.script_to_evaluate_on_commit = 'window.sprites = 0;'
- def ValidateAndMeasurePage(self, _, tab, results):
+ def ValidateAndMeasurePage(self, page, tab, results):
object_count = '$objectcount$'
fps = '$fps$'
tickcount = '$tickcount$'
@@ -50,6 +50,7 @@ class _ScirraMeasurement(page_test.PageTest):
total = int(tab.EvaluateJavaScript('window.sprites'))
results.AddValue(scalar.ScalarValue(
results.current_page, 'Count', 'count', total))
+ super(_ScirraMeasurement, self).ValidateAndMeasurePage(page, tab, results)
@benchmark.Disabled
class ScirraBenchmark(benchmark.Benchmark):

Powered by Google App Engine
This is Rietveld 408576698