Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: tools/perf/benchmarks/robohornet_pro.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/robohornet_pro.py
diff --git a/tools/perf/benchmarks/robohornet_pro.py b/tools/perf/benchmarks/robohornet_pro.py
index 4709ef1422536e5bf2154494a9b06fd5e191b962..b56a2e25796a4a419ad5af841b72fe15bd6013ea 100644
--- a/tools/perf/benchmarks/robohornet_pro.py
+++ b/tools/perf/benchmarks/robohornet_pro.py
@@ -6,19 +6,20 @@
import os
+from measurements import PageTestMeasurement
from metrics import power
from telemetry import benchmark
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import scalar
-class _RobohornetProMeasurement(page_test.PageTest):
+class _RobohornetProMeasurement(PageTestMeasurement):
def __init__(self):
super(_RobohornetProMeasurement, self).__init__()
self._power_metric = None
def CustomizeBrowserOptions(self, options):
+ super(_RobohornetProMeasurement, self).CustomizeBrowserOptions(options)
power.PowerMetric.CustomizeBrowserOptions(options)
def WillStartBrowser(self, platform):
@@ -39,7 +40,8 @@ class _RobohornetProMeasurement(page_test.PageTest):
result = int(tab.EvaluateJavaScript('stopTime - startTime'))
results.AddValue(
scalar.ScalarValue(results.current_page, 'Total', 'ms', result))
-
+ super(_RobohornetProMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
class RobohornetPro(benchmark.Benchmark):

Powered by Google App Engine
This is Rietveld 408576698