Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: tools/perf/benchmarks/indexeddb_perf.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/indexeddb_perf.py
diff --git a/tools/perf/benchmarks/indexeddb_perf.py b/tools/perf/benchmarks/indexeddb_perf.py
index 8db9e54b97c0acd88c1a59be89313fe4501ca26f..12f7740e397b4daf34f09a4840751846215a8f5f 100644
--- a/tools/perf/benchmarks/indexeddb_perf.py
+++ b/tools/perf/benchmarks/indexeddb_perf.py
@@ -22,20 +22,20 @@ Cursors:
import json
import os
+from measurements import PageTestMeasurement
from metrics import memory
from metrics import power
from metrics import v8_object_stats
from telemetry import benchmark
from telemetry.core import util
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import scalar
_V8_COUNTER_NAMES = [
'V8.OsMemoryAllocated',
]
-class _IndexedDbMeasurement(page_test.PageTest):
+class _IndexedDbMeasurement(PageTestMeasurement):
def __init__(self, *args, **kwargs):
super(_IndexedDbMeasurement, self).__init__(*args, **kwargs)
self._memory_metric = None
@@ -83,9 +83,12 @@ class _IndexedDbMeasurement(page_test.PageTest):
total += msec
results.AddValue(scalar.ScalarValue(
results.current_page, 'Total Perf', 'ms', total))
+ super(_IndexedDbMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
def CustomizeBrowserOptions(self, options):
+ super(_IndexedDbMeasurement, self).CustomizeBrowserOptions(options)
memory.MemoryMetric.CustomizeBrowserOptions(options)
power.PowerMetric.CustomizeBrowserOptions(options)
v8_object_stats.V8ObjectStatsMetric.CustomizeBrowserOptions(options)

Powered by Google App Engine
This is Rietveld 408576698