Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: tools/perf/benchmarks/html5gaming.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Add a common subclass to measurements. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/html5gaming.py
diff --git a/tools/perf/benchmarks/html5gaming.py b/tools/perf/benchmarks/html5gaming.py
index 52060f01478169f1ed4da9429dd0287db52c158c..a7d7c8627611d38d6d18efc28ef24f6ed0bcccea 100644
--- a/tools/perf/benchmarks/html5gaming.py
+++ b/tools/perf/benchmarks/html5gaming.py
@@ -12,14 +12,14 @@ score is a indicator for the browser's ability to smoothly run HTML5 games."""
import os
+from measurements import PageTestMeasurement
from telemetry import benchmark
from telemetry.page import page_set
-from telemetry.page import page_test
from telemetry.value import scalar
-class _HTML5GamingMeasurement(page_test.PageTest):
- def ValidateAndMeasurePage(self, _, tab, results):
+class _HTML5GamingMeasurement(PageTestMeasurement):
+ def ValidateAndMeasurePage(self, page, tab, results):
tab.ExecuteJavaScript('benchmark();')
# Default value of score element is 87485, its value is updated with actual
# score when test finish.
@@ -29,7 +29,8 @@ class _HTML5GamingMeasurement(page_test.PageTest):
'document.getElementById("score").innerHTML'))
results.AddValue(
scalar.ScalarValue(results.current_page, 'Score', 'score', result))
-
+ super(_HTML5GamingMeasurement, self).ValidateAndMeasurePage(
+ page, tab, results)
@benchmark.Disabled

Powered by Google App Engine
This is Rietveld 408576698