tools/perf/measurements/startup.py - Issue 714273004: mac: Expose keychain access frequency to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/startup.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep

Patch Set: Comments from dtu. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/measurements/session_restore.py ('K') | « tools/perf/measurements/session_restore.py ('k') | tools/perf/measurements/tab_switching.py » ('j') | tools/perf/metrics/keychain_metric.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/startup.py

diff --git a/tools/perf/measurements/startup.py b/tools/perf/measurements/startup.py

index 8b57a486469e6b8286276653b5fcfd92865b8592..4adcd63d5d01f7b93aacc051fc7ad36c3ed3c9c0 100644

--- a/tools/perf/measurements/startup.py

+++ b/tools/perf/measurements/startup.py

@@ -2,6 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+from metrics import keychain_metric

from metrics import startup_metric

from telemetry.page import page_test

@@ -29,12 +30,14 @@ class Startup(page_test.PageTest):

options.AppendExtraBrowserArgs([

'--enable-stats-collection-bindings'

])

+ keychain_metric.KeychainMetric.CustomizeBrowserOptionsMac(options)

def RunNavigateSteps(self, page, tab):

# Overriden so that no page navigation occurs - startup to the NTP.

pass

def ValidateAndMeasurePage(self, page, tab, results):

+ keychain_metric.KeychainMetric().AddResultsMac(tab, results)

startup_metric.StartupMetric().AddResults(tab, results)