tools/perf/measurements/session_restore.py - Issue 714273004: mac: Expose keychain access frequency to Telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/session_restore.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep

Patch Set: Comments from dtu. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/measurements/page_cycler_unittest.py ('K') | « tools/perf/measurements/page_cycler_unittest.py ('k') | tools/perf/measurements/startup.py » ('j') | tools/perf/metrics/keychain_metric.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/session_restore.py

diff --git a/tools/perf/measurements/session_restore.py b/tools/perf/measurements/session_restore.py

index 26eef4da60f93f81a0f23c1b66698bf590792eb8..ea91450621de777a8a0c606cd7d6a5c5c4719e8d 100644

--- a/tools/perf/measurements/session_restore.py

+++ b/tools/perf/measurements/session_restore.py

@@ -70,11 +70,10 @@ class SessionRestore(startup.Startup):

def ValidateAndMeasurePage(self, page, tab, results):

tab.WaitForDocumentReadyStateToBeComplete()

+ super(SessionRestore, self).ValidateAndMeasurePage(page, tab, results)

# Record CPU usage from browser start to when the foreground page is loaded.

self._cpu_metric.Stop(None, None)

self._cpu_metric.AddResults(tab, results, 'cpu_utilization')

- startup_metric.StartupMetric().AddResults(tab, results)

jeremy 2014/12/09 14:57:17 Why remove this?

erikchen 2014/12/13 02:39:58 The superclass implementation of ValidateAndMeasur

# TODO(jeremy): Measure time to load - first, last and frontmost tab here.