Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: tools/perf/measurements/page_cycler_unittest.py

Issue 714273004: mac: Expose keychain access frequency to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mock_keychain_sleep
Patch Set: Respond to offline comments from tonyg. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/page_cycler_unittest.py
diff --git a/tools/perf/measurements/page_cycler_unittest.py b/tools/perf/measurements/page_cycler_unittest.py
index 164e69f21ca19849cb9a05709be56dcd408231c6..9a5aaf0c61e88a5764165196a52691cea6494dda 100644
--- a/tools/perf/measurements/page_cycler_unittest.py
+++ b/tools/perf/measurements/page_cycler_unittest.py
@@ -103,6 +103,7 @@ class PageCyclerUnitTest(unittest.TestCase):
cold_load_percent = cold_load_percent,
record_v8_object_stats = record_v8_object_stats,
report_speed_index = report_speed_index)
+ cycler.SetInUnitTest(True)
dtu 2014/12/05 01:12:54 Why can't we have this enabled in unit tests as we
erikchen 2014/12/08 23:41:25 I don't understand your comment. My intention is f
dtu 2014/12/09 00:25:03 Sorry, I mean that I think it's generally dangerou
erikchen 2014/12/09 01:26:03 Good point. I've removed the method "SetInUnitTest
options = browser_options.BrowserFinderOptions()
options.browser_options.platform = FakePlatform()
parser = options.CreateParser()

Powered by Google App Engine
This is Rietveld 408576698