Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import unittest | 5 import unittest |
| 6 | 6 |
| 7 from telemetry.core import browser_options | 7 from telemetry.core import browser_options |
| 8 from telemetry.results import page_test_results | 8 from telemetry.results import page_test_results |
| 9 from telemetry.unittest_util import simple_mock | 9 from telemetry.unittest_util import simple_mock |
| 10 from telemetry.user_story import user_story_runner | 10 from telemetry.user_story import user_story_runner |
| (...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 96 | 96 |
| 97 def SetUpCycler(self, page_repeat=1, pageset_repeat=10, cold_load_percent=50, | 97 def SetUpCycler(self, page_repeat=1, pageset_repeat=10, cold_load_percent=50, |
| 98 record_v8_object_stats=False, report_speed_index=False, | 98 record_v8_object_stats=False, report_speed_index=False, |
| 99 setup_memory_module=False): | 99 setup_memory_module=False): |
| 100 cycler = page_cycler.PageCycler( | 100 cycler = page_cycler.PageCycler( |
| 101 page_repeat = page_repeat, | 101 page_repeat = page_repeat, |
| 102 pageset_repeat = pageset_repeat, | 102 pageset_repeat = pageset_repeat, |
| 103 cold_load_percent = cold_load_percent, | 103 cold_load_percent = cold_load_percent, |
| 104 record_v8_object_stats = record_v8_object_stats, | 104 record_v8_object_stats = record_v8_object_stats, |
| 105 report_speed_index = report_speed_index) | 105 report_speed_index = report_speed_index) |
| 106 cycler.SetInUnitTest(True) | |
|
dtu
2014/12/05 01:12:54
Why can't we have this enabled in unit tests as we
erikchen
2014/12/08 23:41:25
I don't understand your comment. My intention is f
dtu
2014/12/09 00:25:03
Sorry, I mean that I think it's generally dangerou
erikchen
2014/12/09 01:26:03
Good point. I've removed the method "SetInUnitTest
| |
| 106 options = browser_options.BrowserFinderOptions() | 107 options = browser_options.BrowserFinderOptions() |
| 107 options.browser_options.platform = FakePlatform() | 108 options.browser_options.platform = FakePlatform() |
| 108 parser = options.CreateParser() | 109 parser = options.CreateParser() |
| 109 user_story_runner.AddCommandLineArgs(parser) | 110 user_story_runner.AddCommandLineArgs(parser) |
| 110 args = ['--page-repeat=%i' % page_repeat, | 111 args = ['--page-repeat=%i' % page_repeat, |
| 111 '--pageset-repeat=%i' % pageset_repeat] | 112 '--pageset-repeat=%i' % pageset_repeat] |
| 112 parser.parse_args(args) | 113 parser.parse_args(args) |
| 113 user_story_runner.ProcessCommandLineArgs(parser, options) | 114 user_story_runner.ProcessCommandLineArgs(parser, options) |
| 114 cycler.CustomizeBrowserOptions(options.browser_options) | 115 cycler.CustomizeBrowserOptions(options.browser_options) |
| 115 | 116 |
| (...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 236 # does an initial navigate to avoid paying for a cross-renderer navigation. | 237 # does an initial navigate to avoid paying for a cross-renderer navigation. |
| 237 cycler = self.SetUpCycler(setup_memory_module=True) | 238 cycler = self.SetUpCycler(setup_memory_module=True) |
| 238 pages = [FakePage('file://fakepage1.com'), FakePage('file://fakepage2.com')] | 239 pages = [FakePage('file://fakepage1.com'), FakePage('file://fakepage2.com')] |
| 239 tab = FakeTab() | 240 tab = FakeTab() |
| 240 | 241 |
| 241 self.assertEqual([], tab.navigated_urls) | 242 self.assertEqual([], tab.navigated_urls) |
| 242 for page in pages * 2: | 243 for page in pages * 2: |
| 243 cycler.WillNavigateToPage(page, tab) | 244 cycler.WillNavigateToPage(page, tab) |
| 244 self.assertEqual( | 245 self.assertEqual( |
| 245 ['http://fakeserver:99999/nonexistent.html'], tab.navigated_urls) | 246 ['http://fakeserver:99999/nonexistent.html'], tab.navigated_urls) |
| OLD | NEW |