Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 714063002: ARIA role spinbutton should expose AXRole as AXIncrementor. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ARIA role spinbutton should expose AXRole as AXIncrementor. According to latest editor's draft http://rawgit.com/w3c/aria/master/core-aam/core-aam.html ARIA role spinbutton would be exposed as below on mac: AXRole: AXIncrementor AXSubrole: <nil> AXRoleDescription: 'stepper' In this CL, I am also removing Unused role 'Incrementor'. BUG=385014 Committed: https://crrev.com/120e221d1ab712b1a070ffe401506afe54565a84 Cr-Commit-Position: refs/heads/master@{#303966}

Patch Set 1 #

Patch Set 2 : updating expectations #

Patch Set 3 : removing input-type number changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-spinbutton.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-spinbutton-expected-mac.txt View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-valuemax.html View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-valuemax-expected-mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-valuemin.html View 1 2 chunks +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-valuemin-expected-mac.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-date-expected-mac.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/input-datetime-local-expected-mac.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M content/test/data/accessibility/input-month-expected-mac.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-time-expected-mac.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/data/accessibility/input-week-expected-mac.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
shreeramk
@Dominic: PTAL. This change https://codereview.chromium.org/718433002/ has been merged, but it seems its not proper yet ...
6 years, 1 month ago (2014-11-12 08:19:51 UTC) #1
dmazzoni
lgtm
6 years, 1 month ago (2014-11-12 19:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714063002/40001
6 years, 1 month ago (2014-11-13 01:37:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/714063002/40001
6 years, 1 month ago (2014-11-13 01:38:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-13 02:38:14 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 02:38:50 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/120e221d1ab712b1a070ffe401506afe54565a84
Cr-Commit-Position: refs/heads/master@{#303966}

Powered by Google App Engine
This is Rietveld 408576698