content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 714063002: ARIA role spinbutton should expose AXRole as AXIncrementor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 714063002: ARIA role spinbutton should expose AXRole as AXIncrementor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removing input-type number changes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index 0e651f19875153f415c7b2ff525f1645faf093df..a0cf3337164b0a59bf918ebd316e86759f0bdea1 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -843,6 +843,7 @@ NSDictionary* attributeToMethodNameMap = nil;

return [NSNumber numberWithInt:value];

} else if ([role isEqualToString:NSAccessibilityProgressIndicatorRole] ||

[role isEqualToString:NSAccessibilitySliderRole] ||

+ [role isEqualToString:NSAccessibilityIncrementorRole] ||

[role isEqualToString:NSAccessibilityScrollBarRole]) {

float floatValue;

if (browserAccessibility_->GetFloatAttribute(

@@ -1264,6 +1265,7 @@ NSDictionary* attributeToMethodNameMap = nil;

[ret addObject:NSAccessibilityTabsAttribute];

} else if ([role isEqualToString:NSAccessibilityProgressIndicatorRole] ||

[role isEqualToString:NSAccessibilitySliderRole] ||

+ [role isEqualToString:NSAccessibilityIncrementorRole] ||

[role isEqualToString:NSAccessibilityScrollBarRole]) {

[ret addObjectsFromArray:[NSArray arrayWithObjects:

NSAccessibilityMaxValueAttribute,

« no previous file with comments | « chrome/common/extensions/api/automation.idl ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »