Add the case for figure in title() and accessibilityDescription().

Add textUnderElement of figcaption for figure in title
and add the case for figure in accessibilityDescription.
To follow the spec,
http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#el-figure,
textUnderElement of figcaption is used for name of figure.

BUG=282035
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185267

[je_julie(Not used), 2014-11-10 15:35:27]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2014-11-10 15:40:41]

Dominic,

This patch makes figure element use textUnderElement of figcaption for name
attribute as the spec described.
http://rawgit.com/w3c/aria/master/html-aam/html-aam.html#el-figure

Before landing this patch,
I should disable figcaption AX TC.
So, I uploaded cl for disabling it, https://codereview.chromium.org/714673002/.

And here is new results for it.
https://codereview.chromium.org/713883002/.
I'll leave it as WIP until this patch is landed.

PTAL.

[dmazzoni, 2014-11-10 17:16:10]

https://codereview.chromium.org/713873002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/713873002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:1258: return
child->textUnderElement();
I think this should be child->title() or child->accessibilityDescription() or
something else that calls textUnderElement indirectly but also respects
aria-label, etc.

For example:

<figure>
  <figcaption aria-label="Alternate caption">Original caption</figcaption>
</figure>

Alternatively, this should be done in accessibilityDescription - i.e. leave this
code correct for title() but have accessibilityDescription check the figcaption.

[je_julie(Not used), 2014-11-11 15:38:51]

https://codereview.chromium.org/713873002/diff/1/Source/core/accessibility/AX...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/713873002/diff/1/Source/core/accessibility/AX...
Source/core/accessibility/AXNodeObject.cpp:1258: return
child->textUnderElement();
Thanks for your idea.
I took the 2nd suggestion because I think it's better to keep consistency for
functions.
I updated patchset and I verified that I can get "Alternate caption" for name on
Windows with example below.
Could you take a look at the 2nd patchset?

On 2014/11/10 17:16:10, dmazzoni wrote:
> I think this should be child->title() or child->accessibilityDescription() or
> something else that calls textUnderElement indirectly but also respects
> aria-label, etc.
> 
> For example:
> 
> <figure>
>   <figcaption aria-label="Alternate caption">Original caption</figcaption>
> </figure>
> 
> Alternatively, this should be done in accessibilityDescription - i.e. leave
this
> code correct for title() but have accessibilityDescription check the
figcaption.
>

[dmazzoni, 2014-11-12 06:03:04]

lgtm

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXNodeObject.cpp:1184: AXObject*
AXNodeObject::searchAXObjectFromChild(const HTMLQualifiedName& node) const
The argument name should be tagName instead of node

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXNodeObject.h (right):

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXNodeObject.h:197: AXObject*
searchAXObjectFromChild(const HTMLQualifiedName&) const;
Great idea for a helper function - I'd call it something like
findChildWithTagName

[je_julie(Not used), 2014-11-12 13:07:04]

Dominic,
I updated patch with changing the parameter name.
PTAL.

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXNodeObject.cpp (right):

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXNodeObject.cpp:1184: AXObject*
AXNodeObject::searchAXObjectFromChild(const HTMLQualifiedName& node) const
On 2014/11/12 06:03:03, dmazzoni wrote:
> The argument name should be tagName instead of node
You're right. I updated the parameter name.

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
File Source/core/accessibility/AXNodeObject.h (right):

https://codereview.chromium.org/713873002/diff/20001/Source/core/accessibilit...
Source/core/accessibility/AXNodeObject.h:197: AXObject*
searchAXObjectFromChild(const HTMLQualifiedName&) const;
On 2014/11/12 06:03:03, dmazzoni wrote:
> Great idea for a helper function - I'd call it something like
> findChildWithTagName
Thanks!

[dmazzoni, 2014-11-12 19:54:38]

On 2014/11/12 13:07:04, je_julie wrote:
> > Great idea for a helper function - I'd call it something like
> > findChildWithTagName
> Thanks!

Sorry, to be clear - please change the function name from
searchAXObjectFromChild to findChildWithTagName

No need to wait for re-review after making that change, lgtm after you fix that
- thanks.

[je_julie(Not used), 2014-11-13 00:53:07]

On 2014/11/12 19:54:38, dmazzoni wrote:
> Sorry, to be clear - please change the function name from
> searchAXObjectFromChild to findChildWithTagName
> 
> No need to wait for re-review after making that change, lgtm after you fix
that
> - thanks.

Thanks for suggestion for nice naming.
I'll update and commit it.

[je_julie(Not used), 2014-11-13 03:52:30]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2014-11-13 03:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/713873002/80001

[commit-bot: I haz the power, 2014-11-13 04:35:18]

Committed patchset #5 (id:80001) as 185267