Add the case for figure in title() and accessibilityDescription().

Source/core/accessibility/AXNodeObject.cpp

 /*
 * Copyright (C) 2012, Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 1233 matching lines @@
     case MenuButtonRole:
     case MenuItemRole:
     case MenuItemCheckBoxRole:
     case MenuItemRadioRole:
     case RadioButtonRole:
     case TabRole:
         return textUnderElement();
     // SVGRoots should not use the text under itself as a title. That could include the text of objects like <text>.
     case SVGRootRole:
         return String();
+    case FigureRole:
+        for (AXObject* child = firstChild(); child; child = child->nextSibling()) {
+            Node* childNode = child->node();
+            if (childNode && childNode->hasTagName(figcaptionTag))
+                return child->textUnderElement();

[dmazzoni, 2014/11/10 17:16:10]

I think this should be child->title() or child->accessibilityDescription() or
something else that calls textUnderElement indirectly but also respects
aria-label, etc.

For example:

<figure>
  <figcaption aria-label="Alternate caption">Original caption</figcaption>
</figure>

Alternatively, this should be done in accessibilityDescription - i.e. leave this
code correct for title() but have accessibilityDescription check the figcaption.

[je_julie(Not used), 2014/11/11 15:38:51]

Thanks for your idea.
I took the 2nd suggestion because I think it's better to keep consistency for
functions.
I updated patchset and I verified that I can get "Alternate caption" for name on
Windows with example below.
Could you take a look at the 2nd patchset?

On 2014/11/10 17:16:10, dmazzoni wrote:

+        }
     default:
         break;
     }
 
     if (isHeading() || isLink())
         return textUnderElement();
 
     // If it's focusable but it's not content editable or a known control type, then it will appear to
     // the user as a single atomic object, so we should use its text as the default title.
     if (isGenericFocusableElement())
@@ skipping 510 matching lines @@
     float range = maxValueForRange() - minValueForRange();
     float value = valueForRange();
 
     value += range * (percentChange / 100);
     setValue(String::number(value));
 
     axObjectCache()->postNotification(node(), AXObjectCacheImpl::AXValueChanged, true);
 }
 
 } // namespace blink