Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 713783002: Revert of Moving background animation ticking from LayerTreeHostImpl into the Scheduler. (Closed)

Created:
6 years, 1 month ago by mithro-old
Modified:
6 years, 1 month ago
Reviewers:
danakj, ajuma, brianderson, Sami
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@scheduler-timesource-refactor
Project:
chromium
Visibility:
Public.

Description

Revert of Moving background animation ticking from LayerTreeHostImpl into the Scheduler. (patchset #10 id:480001 of https://codereview.chromium.org/595973002/) Reason for revert: Reverting because it breaks the following interactive_ui_tests; * InterruptedAutoStartEnrollment * LoginUIVisible * PRE_InterruptedAutoStartEnrollment * PRE_LoginUIVisible The failure log is; [27898:27924:1109/213628:FATAL:layer_animation_controller.cc(215)] Check failed: last_tick_time_ != base::TimeTicks(). #0 0x7f92b9beb75e base::debug::StackTrace::StackTrace() #1 0x7f92b9c7ec82 logging::LogMessage::~LogMessage() #2 0x7f92b8cdafc4 cc::LayerAnimationController::UpdateState() #3 0x7f92b8fe9474 cc::LayerTreeHostImpl::UpdateAnimationState() #4 0x7f92b902ecf4 cc::ThreadProxy::DrawSwapInternal() #5 0x7f92b902f542 cc::ThreadProxy::ScheduledActionDrawAndSwapIfPossible() #6 0x7f92b902f59c cc::ThreadProxy::ScheduledActionDrawAndSwapIfPossible() #7 0x7f92b8f83324 cc::Scheduler::DrawAndSwapIfPossible() #8 0x7f92b8f80541 cc::Scheduler::ProcessScheduledActions() #9 0x7f92b8f7f54d cc::Scheduler::OnBeginImplFrameDeadline() Original issue's description: > Moving background animation ticking from LayerTreeHostImpl into the Scheduler. > > Background ticking currently happens in the LayerTreeHostImpl, this makes it very hard to preserve the monotonicity guarantee needed by frame times. http://crrev.com/267783004 set up the scheduler to become the source of background ticks and this CL makes use of that functionality. > > BUG=345459 > > Committed: https://crrev.com/4df3c4366015739a7c6b6c1539a8d7c9198e38ef > Cr-Commit-Position: refs/heads/master@{#302757} > > Committed: https://crrev.com/185438b3e5e3f43ce2996da0022f510fbe193a6e > Cr-Commit-Position: refs/heads/master@{#303423} TBR=danakj@chromium.org,brianderson@chromium.org,skyostil@chromium.org,ajuma@chromium.org NOTREECHECKS=true NOTRY=true BUG=345459 Committed: https://crrev.com/cfdec29c10b50750d042f4bcfdce3ccb56b4cd81 Cr-Commit-Position: refs/heads/master@{#303426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -71 lines) Patch
M cc/scheduler/scheduler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_settings.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 3 chunks +15 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 3 chunks +8 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 5 chunks +7 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 4 chunks +100 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 10 chunks +19 lines, -25 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/thread_proxy.cc View 5 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mithro-old
Created Revert of Moving background animation ticking from LayerTreeHostImpl into the Scheduler.
6 years, 1 month ago (2014-11-10 06:20:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713783002/1
6 years, 1 month ago (2014-11-10 06:21:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-10 06:21:55 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 06:22:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfdec29c10b50750d042f4bcfdce3ccb56b4cd81
Cr-Commit-Position: refs/heads/master@{#303426}

Powered by Google App Engine
This is Rietveld 408576698