Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 713553002: Clean up forward declarations in core/rendering and core/painting (Closed)

Created:
6 years, 1 month ago by zhaoze.zhou
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in core/rendering and core/painting These forward references are not needed anymore. After this patch, core/rendering and core/painting has no unneeded forward references any more. This patch also move some forward declarations into correct header files. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185019

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -26 lines) Patch
M Source/core/paint/BlockFlowPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/BoxPainter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/LayerPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/ReplicaPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/SVGImagePainter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/ScrollbarPainter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/paint/VideoPainter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/paint/ViewDisplayList.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/ClipRect.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/ClipRectsCache.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/LayoutState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLineBoxList.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumFontProvider.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderingContext.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
zhaoze.zhou
On 2014/11/07 21:30:10, zhaoze.zhou wrote: > mailto:zhaoze.zhou@partner.samsung.com changed reviewers: > + mailto:schenney@google.com PTAL. thanks.
6 years, 1 month ago (2014-11-07 21:37:23 UTC) #3
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-09 23:42:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713553002/20001
6 years, 1 month ago (2014-11-10 03:05:28 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 03:08:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185019

Powered by Google App Engine
This is Rietveld 408576698