Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 713413003: harmony-scoping: better error messages for let declarations in sloppy mode. (Closed)

Created:
6 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

harmony-scoping: better error messages for let declarations in sloppy mode. R=rossberg@chromium.org BUG=v8:2198 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/c32114f1dcb1102c685007a5da813c664ded94cf

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -1 line) Patch
M src/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M src/preparser.cc View 4 chunks +17 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/block-non-strict-errors.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 1 month ago (2014-11-18 01:07:21 UTC) #2
rossberg
LGTM https://codereview.chromium.org/713413003/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/713413003/diff/20001/test/cctest/test-parsing.cc#newcode4437 test/cctest/test-parsing.cc:4437: TEST(LexicalScopingNonStrictMode) { Nit: SloppyMode? :)
6 years, 1 month ago (2014-11-18 10:32:58 UTC) #3
Dmitry Lomov (no reviews)
Landing https://codereview.chromium.org/713413003/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/713413003/diff/20001/test/cctest/test-parsing.cc#newcode4437 test/cctest/test-parsing.cc:4437: TEST(LexicalScopingNonStrictMode) { On 2014/11/18 10:32:58, rossberg wrote: > ...
6 years, 1 month ago (2014-11-18 18:22:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/713413003/40001
6 years, 1 month ago (2014-11-18 18:23:11 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 18:51:26 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001)

Powered by Google App Engine
This is Rietveld 408576698