Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Side by Side Diff: test/cctest/test-parsing.cc

Issue 713413003: harmony-scoping: better error messages for let declarations in sloppy mode. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Patch for landing Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/preparser.cc ('k') | test/mjsunit/harmony/block-non-strict-errors.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4414 matching lines...) Expand 10 before | Expand all | Expand 10 after
4425 "`foo${\n a`", 4425 "`foo${\n a`",
4426 "`foo${\r\n a`", 4426 "`foo${\r\n a`",
4427 "`foo${\r a`", 4427 "`foo${\r a`",
4428 "`foo${fn(}`", 4428 "`foo${fn(}`",
4429 "`foo${1 if}`", 4429 "`foo${1 if}`",
4430 NULL}; 4430 NULL};
4431 static const ParserFlag always_flags[] = {kAllowHarmonyTemplates}; 4431 static const ParserFlag always_flags[] = {kAllowHarmonyTemplates};
4432 RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags, 4432 RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
4433 arraysize(always_flags)); 4433 arraysize(always_flags));
4434 } 4434 }
4435
4436
4437 TEST(LexicalScopingSloppyMode) {
4438 const char* context_data[][2] = {
4439 {"", ""},
4440 {"function f() {", "}"},
4441 {"{", "}"},
4442 {NULL, NULL}};
4443 const char* bad_data[] = {
4444 "let x = 1;",
4445 "for(let x = 1;;){}",
4446 "for(let x of []){}",
4447 "for(let x in []){}",
4448 NULL};
4449 static const ParserFlag always_flags[] = {kAllowHarmonyScoping};
4450 RunParserSyncTest(context_data, bad_data, kError, NULL, 0, always_flags,
4451 arraysize(always_flags));
4452
4453 const char* good_data[] = {
4454 "let = 1;",
4455 "for(let = 1;;){}",
4456 NULL};
4457 RunParserSyncTest(context_data, good_data, kSuccess, NULL, 0, always_flags,
4458 arraysize(always_flags));
4459 }
OLDNEW
« no previous file with comments | « src/preparser.cc ('k') | test/mjsunit/harmony/block-non-strict-errors.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698