Issue 713223002: Abstract string building in JSON-stringifier into IncrementalStringBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 713223002: Abstract string building in JSON-stringifier into IncrementalStringBuilder. (Closed)

Created:
6 years, 1 month ago by Yang

Modified:
6 years, 1 month ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Abstract string building in JSON-stringifier into IncrementalStringBuilder. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25276

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+371 lines, -592 lines)			Patch
M	BUILD.gn	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/json-stringifier.h	View	24 chunks	+84 lines, -256 lines	0 comments	Download
M	src/runtime/runtime-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime/runtime-strings.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	src/runtime/string-builder.h	View	1 chunk	+0 lines, -296 lines	0 comments	Download
A +	src/string-builder.h	View	3 chunks	+170 lines, -36 lines	0 comments	Download
A	src/string-builder.cc	View	1 chunk	+111 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Yang

6 years, 1 month ago (2014-11-12 08:04:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25276 (presubmit successful).