BUILD.gn - Issue 713223002: Abstract string building in JSON-stringifier into IncrementalStringBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: BUILD.gn

Issue 713223002: Abstract string building in JSON-stringifier into IncrementalStringBuilder. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index d77931c7ec5e9bde20b33f9692daaecf67be0078..bc9941aa1e8b86f15a447837d5e2449d9a8b973d 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -875,7 +875,6 @@ source_set("v8_base") {

"src/runtime/runtime-utils.h",

"src/runtime/runtime.cc",

"src/runtime/runtime.h",

- "src/runtime/string-builder.h",

"src/safepoint-table.cc",

"src/safepoint-table.h",

"src/sampler.cc",

@@ -895,6 +894,8 @@ source_set("v8_base") {

"src/snapshot-source-sink.cc",

"src/snapshot-source-sink.h",

"src/snapshot.h",

+ "src/string-builder.h",

+ "src/string-builder.c",

"src/string-search.cc",

"src/string-search.h",

"src/string-stream.cc",

« no previous file with comments | « no previous file | src/json-stringifier.h » ('j') | no next file with comments »