Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 712813002: Count internal use of DOMImplementation::hasFeature() returning false (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Count internal use of DOMImplementation::hasFeature() returning false This is the only internal usage of DOMImplementation::hasFeature(), and the only way that svg:requiredFeatures is observable, other than the it->isEmpty() case. If usage is low, DOMImplementation.hasFeature() and this internal usage can be changed together, see https://groups.google.com/a/chromium.org/d/msg/blink-dev/r2aARnIHG4k/_dN33g65mYgJ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185133

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename counter #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGAnimationElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPatternElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTests.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGTests.cpp View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-08 23:10:41 UTC) #2
kouhei (in TOK)
https://codereview.chromium.org/712813002/diff/1/Source/core/svg/SVGTests.cpp File Source/core/svg/SVGTests.cpp (right): https://codereview.chromium.org/712813002/diff/1/Source/core/svg/SVGTests.cpp#newcode59 Source/core/svg/SVGTests.cpp:59: UseCounter::count(document, UseCounter::SVGRequiredFeatures); This UseCounter is counted if requiredFeatures is ...
6 years, 1 month ago (2014-11-08 23:51:42 UTC) #4
Stephen Chennney
What are you hoping to discover? We already have, and have had for quite some ...
6 years, 1 month ago (2014-11-10 14:54:28 UTC) #6
Stephen Chennney
On 2014/11/10 14:54:28, Stephen Chenney wrote: > What are you hoping to discover? We already ...
6 years, 1 month ago (2014-11-10 14:59:32 UTC) #7
philipj_slow
rename counter
6 years, 1 month ago (2014-11-10 15:21:03 UTC) #8
philipj_slow
I've renamed the counter and updated the commit message, PTAL.
6 years, 1 month ago (2014-11-10 15:58:30 UTC) #9
Stephen Chennney
LGTM. Wow, it took me a long time to find the one place where we ...
6 years, 1 month ago (2014-11-10 16:16:21 UTC) #10
philipj_slow
On 2014/11/10 16:16:21, Stephen Chenney wrote: > LGTM. Wow, it took me a long time ...
6 years, 1 month ago (2014-11-10 20:39:58 UTC) #11
kouhei (in TOK)
lgtm
6 years, 1 month ago (2014-11-10 23:32:01 UTC) #12
philipj_slow
rebase
6 years, 1 month ago (2014-11-11 08:56:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712813002/40001
6 years, 1 month ago (2014-11-11 08:57:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35782)
6 years, 1 month ago (2014-11-11 11:15:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712813002/40001
6 years, 1 month ago (2014-11-11 16:11:55 UTC) #19
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 17:06:19 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 185133

Powered by Google App Engine
This is Rietveld 408576698