Count internal use of DOMImplementation::hasFeature() returning false

Source/core/svg/SVGTests.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 
 #include "core/svg/SVGTests.h"
 
 #include "core/SVGNames.h"
 #include "core/dom/DOMImplementation.h"
+#include "core/frame/UseCounter.h"
+#include "core/svg/SVGElement.h"
 #include "platform/Language.h"
-#include "core/svg/SVGElement.h"
 
 namespace blink {
 
 SVGTests::SVGTests(SVGElement* contextElement)
     : m_requiredFeatures(SVGStaticStringList::create(contextElement, SVGNames::requiredFeaturesAttr))
     , m_requiredExtensions(SVGStaticStringList::create(contextElement, SVGNames::requiredExtensionsAttr))
     , m_systemLanguage(SVGStaticStringList::create(contextElement, SVGNames::systemLanguageAttr))
 {
     ASSERT(contextElement);
 
     contextElement->addToPropertyMap(m_requiredFeatures);
     contextElement->addToPropertyMap(m_requiredExtensions);
     contextElement->addToPropertyMap(m_systemLanguage);
 }
 
 bool SVGTests::hasExtension(const String&)
 {
     // FIXME: Implement me!
     return false;
 }
 
-bool SVGTests::isValid() const
+bool SVGTests::isValid(Document& document) const
 {
     if (m_requiredFeatures->isSpecified()) {
         const Vector<String>& requiredFeatures = m_requiredFeatures->value()->values();
         Vector<String>::const_iterator it = requiredFeatures.begin();
         Vector<String>::const_iterator itEnd = requiredFeatures.end();
         for (; it != itEnd; ++it) {
-            if (it->isEmpty() || !DOMImplementation::hasFeature(*it, String()))
+            if (it->isEmpty() || !DOMImplementation::hasFeature(*it, String())) {
+                UseCounter::count(document, UseCounter::SVGRequiredFeatures);

[kouhei (in TOK), 2014/11/08 23:51:42]

This UseCounter is counted if requiredFeatures is used and if it is used to
disable displaying the nodes.

Would you rename the UseCounter name and update the CL description that this is
clear?

                 return false;
+            }
         }
     }
 
     if (m_systemLanguage->isSpecified()) {
         bool matchFound = false;
 
         const Vector<String>& systemLanguage = m_systemLanguage->value()->values();
         Vector<String>::const_iterator it = systemLanguage.begin();
         Vector<String>::const_iterator itEnd = systemLanguage.end();
         for (; it != itEnd; ++it) {
@@ skipping 41 matching lines @@
 }
 
 void SVGTests::addSupportedAttributes(HashSet<QualifiedName>& supportedAttributes)
 {
     supportedAttributes.add(SVGNames::requiredFeaturesAttr);
     supportedAttributes.add(SVGNames::requiredExtensionsAttr);
     supportedAttributes.add(SVGNames::systemLanguageAttr);
 }
 
 }