Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 712723002: suppress link disambiguation popup when virtual keyboard requested (Closed)

Created:
6 years, 1 month ago by luken
Modified:
6 years, 1 month ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

suppress link disambiguation popup when virtual keyboard requested Currently Blink indicates the link disambiguation popup should be shown even if one of the tap-able elements is the focused text input element, which will also cause the virtual keyboard to be shown on Windows touch input devices. Unfortunately showing the link disambig popup breaks the virtual keyboard input. This CL suppresses the showing of a link disambiguation popup whenever a virtual keyboard is requested to be displayed. Follow-on work is needed to tune the Blink heuristic to decide to not show the link disambiguation popup based on the kind of selectable elements within the ambiguous touch area. BUG=428258 Committed: https://crrev.com/dc35e7fb486859c046f7417058168f56b5b81141 Cr-Commit-Position: refs/heads/master@{#303501}

Patch Set 1 #

Patch Set 2 : fix linux build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M content/browser/renderer_host/render_view_host_delegate.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
luken
6 years, 1 month ago (2014-11-07 23:08:05 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm!
6 years, 1 month ago (2014-11-10 18:18:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712723002/20001
6 years, 1 month ago (2014-11-10 18:19:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-10 19:06:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 19:06:58 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc35e7fb486859c046f7417058168f56b5b81141
Cr-Commit-Position: refs/heads/master@{#303501}

Powered by Google App Engine
This is Rietveld 408576698