content/browser/renderer_host/render_view_host_impl.cc - Issue 712723002: suppress link disambiguation popup when virtual keyboard requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 712723002: suppress link disambiguation popup when virtual keyboard requested (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix linux build Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.cc

diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc

index ed92999213e712fb0eb887cf285507bf6eb858c4..1387cfb76bf14849897804344dd6a48b0e01e6bf 100644

--- a/content/browser/renderer_host/render_view_host_impl.cc

+++ b/content/browser/renderer_host/render_view_host_impl.cc

@@ -1206,6 +1206,7 @@ void RenderViewHostImpl::OnFocusedNodeChanged(bool is_editable_node) {

#if defined(OS_WIN)

if (!is_editable_node && virtual_keyboard_requested_) {

virtual_keyboard_requested_ = false;

+ delegate_->SetIsVirtualKeyboardRequested(false);

BrowserThread::PostDelayedTask(

BrowserThread::UI, FROM_HERE,

base::Bind(base::IgnoreResult(&DismissVirtualKeyboardTask)),

@@ -1423,8 +1424,10 @@ void RenderViewHostImpl::OnFocusedNodeTouched(bool editable) {

#if defined(OS_WIN)

if (editable) {

virtual_keyboard_requested_ = base::win::DisplayVirtualKeyboard();

+ delegate_->SetIsVirtualKeyboardRequested(true);

} else {

virtual_keyboard_requested_ = false;

+ delegate_->SetIsVirtualKeyboardRequested(false);

base::win::DismissVirtualKeyboard();

}

#endif