IPC: a way for browsertests to simulate the appearance of a malicious IPC.

IPC: a way for security exploit browsertests to simulate the appearance of a malicious IPC.

Use this to add a SecurityExploitBrowserTest for http://crbug.com/429922

Fix SecurityExploitBrowserTests on Android. Re-enable SecurityExploitBrowserTests on Android, except for two issues (1) the new test, which is actually disabled because of http://crbug.com/432737, discovered while developing this CL and (2) SetWebUIProperty, which is disabled because of http://crbug.com/433068, also discovered while developing this CL. Moral of the story being: never try.

BUG=429922, 432737, 338023, 433068
TEST=content_browsertests

Committed: https://crrev.com/4c8dfd482ad484f2402a5d9bea921870f3ea5d89
Cr-Commit-Position: refs/heads/master@{#304170}

[ncarter (slow), 2014-11-07 22:21:24]

nick@chromium.org changed reviewers:
+ creis@chromium.org, tsepez@chromium.org

[ncarter (slow), 2014-11-07 22:21:25]

tsepez@chromium.org: Please review changes in ipc
creis@chromium.org: Please review the new browsertest

[Tom Sepez, 2014-11-07 23:28:41]

Nick, is there a way you could build the new code as part of a browsertest
target rather than as part of the IPC component that actually ships?  Thanks.

[ncarter (slow), 2014-11-08 00:12:55]

On 2014/11/07 23:28:41, Tom Sepez wrote:
> Nick, is there a way you could build the new code as part of a browsertest
> target rather than as part of the IPC component that actually ships?  Thanks.

Yes, done. Thanks for suggesting this. I had looked around for a way to do this
but totally forgot to look in the .gyp (vs. gypi) file.

[Charlie Reis, 2014-11-08 00:21:05]

Thanks; test LGTM.

[Tom Sepez, 2014-11-08 00:26:31]

lgtm

https://codereview.chromium.org/712713002/diff/100001/ipc/ipc_security_test_u...
File ipc/ipc_security_test_util.cc (right):

https://codereview.chromium.org/712713002/diff/100001/ipc/ipc_security_test_u...
ipc/ipc_security_test_util.cc:19:
&IPC::ChannelProxy::Context::OnMessageReceived),
nit: indentation style.  I thought the deal was to indent 4 on a new line if the
argument was too long to align with the opening paren.

[ncarter (slow), 2014-11-08 00:43:05]

https://codereview.chromium.org/712713002/diff/100001/ipc/ipc_security_test_u...
File ipc/ipc_security_test_util.cc (right):

https://codereview.chromium.org/712713002/diff/100001/ipc/ipc_security_test_u...
ipc/ipc_security_test_util.cc:19:
&IPC::ChannelProxy::Context::OnMessageReceived),
On 2014/11/08 00:26:31, Tom Sepez wrote:
> nit: indentation style.  I thought the deal was to indent 4 on a new line if
the
> argument was too long to align with the opening paren.

This was from clang-format. But I agree this was hard to read, so I pulled the
callback into a local for better formatting.

[ncarter (slow), 2014-11-08 00:43:09]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2014-11-08 00:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712713002/120001

[commit-bot: I haz the power, 2014-11-08 02:31:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-08 02:31:41]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[ncarter (slow), 2014-11-13 22:21:41]

charlie: this is finally ready. please review diffs between #7 and current.

[Charlie Reis, 2014-11-14 00:13:27]

LGTM

https://codereview.chromium.org/712713002/diff/200001/content/browser/securit...
File content/browser/security_exploit_browsertest.cc (right):

https://codereview.chromium.org/712713002/diff/200001/content/browser/securit...
content/browser/security_exploit_browsertest.cc:51:
EXPECT_EQ(base::ASCIIToUTF16("OK"), shell->web_contents()->GetTitle());
I think we can put EXPECT_TRUE on the NavigateToURL line instead, now that
Alex's r304064 has landed.

https://codereview.chromium.org/712713002/diff/200001/content/browser/securit...
content/browser/security_exploit_browsertest.cc:250:
ASSERT_TRUE(interstitial_page->GetDelegateForTesting() == interstitial);
nit: ASSERT_EQ

[ncarter (slow), 2014-11-14 00:14:59]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2014-11-14 00:17:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712713002/200001

[commit-bot: I haz the power, 2014-11-14 04:12:01]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2014-11-14 04:13:35]

Patchset 11 (id:??) landed as
https://crrev.com/4c8dfd482ad484f2402a5d9bea921870f3ea5d89
Cr-Commit-Position: refs/heads/master@{#304170}