LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Break containingBlock() into pieces for locateFlowThreadContainingBlock(). Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

diff --git a/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html b/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

deleted file mode 100644

index 736a4cc9e7fd0067af976703182cb56ad5d38829..0000000000000000000000000000000000000000

--- a/LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

+++ /dev/null

@@ -1,16 +0,0 @@

-<!doctype html>

-<html>

- <head>

- <style type="text/css">

- #article1 { -webkit-columns: 1; }

- #p1 { -webkit-column-span: all; }

- </style>

- </head>

- <body>

- <div id="article1">

- <p id="p1">PASS</p>

- </div>

- <div>Test passes if it doesn't crash or assert.</div>

- <div>Test added as part of <a href="https://code.google.com/p/chromium/issues/detail?id=242129">242129 - ASSERTION FAILED: !node || node->isElementNode(), UNKNOWN in WebCore::RenderBlock::clone</a></div>

Julien - ping for review 2014/11/26 21:09:00 What's wrong with this test?

mstensho (USE GERRIT) 2014/11/27 21:20:29 The test and the ref are 100% identical. That does

- </body>

-</html>