LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Break containingBlock() into pieces for locateFlowThreadContainingBlock(). Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!doctype html>

2 <html>

3 <head>

4 <style type="text/css">

5 #article1 { -webkit-columns: 1; }

6 #p1 { -webkit-column-span: all; }

7 </style>

8 </head>

9 <body>

10 <div id="article1">

11 <p id="p1">PASS</p>

12 </div>

13 <div>Test passes if it doesn't crash or assert.</div>

14 <div>Test added as part of <a href="https://code.google.com/p/chromium/i ssues/detail?id=242129">242129 - ASSERTION FAILED: !node \|\| node->isElementNode( ), UNKNOWN in WebCore::RenderBlock::clone</a></div>
Julien - ping for review 2014/11/26 21:09:00 What's wrong with this test? What's wrong with this test? mstensho (USE GERRIT) 2014/11/27 21:20:29 The test and the ref are 100% identical. That does Show quoted text On 2014/11/26 21:09:00, Julien Chaffraix - PST wrote: > What's wrong with this test? The test and the ref are 100% identical. That doesn't really matter if you want to catch crashers, of course, but I thought it was silly. See the commit comment. The new test fast/multicol/span/sole-spanner.html is the replacement.
15 </body>

16 </html>

OLD	NEW