Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 712433002: Revert of [Android] Support unfocusable container views. (Closed)

Created:
6 years, 1 month ago by Nicolas Zea
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Support unfocusable container views. (patchset #4 id:60001 of https://codereview.chromium.org/701233002/) Reason for revert: Introduced flake into WebRTCBrowserTest.* http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=23952 Example: Value of: ExecuteScriptAndExtractString(shell()->web_contents(), javascript, &result) Actual: false Expected: true From javascript: ../../content/test/webrtc_content_browsertest_base.cc:71: Failure Failed [INFO:CONSOLE(883)] "Receiving remote stream...", source: http://127.0.0.1:50076/media/peerconnection-call.html (883) [INFO:CONSOLE(859)] "Receiving answer...", source: http://127.0.0.1:50076/media/peerconnection-call.html (859) [ FAILED ] WebRtcBrowserTest.AddTwoMediaStreamsToOnePC, where TypeParam = and GetParam() = (2180 ms) Original issue's description: > [Android] Support unfocusable container views. > > If the ContentViewCore container view is not focusable (which can > happen when it's emebedded in an app via android webview), we > were clearing the RWHVA notion of focus when the RenderView was > swapped out. As the view is never focusable again, chromium never > considers this view focused and as such, text selection did not > function. > > We support this type of container view by always treating it focused > from Chromium's point of view. > > BUG=430859 (internal b/18066784) > > Committed: https://crrev.com/9074d9fc9119ef4d2223f6c993d1a1b67a0bea7c > Cr-Commit-Position: refs/heads/master@{#303071} TBR=jdduke@chromium.org,benm@chromium.org NOTREECHECKS=true NOTRY=true BUG=430859 (internal b/18066784) Committed: https://crrev.com/1906fd177547e131f1320346df164a5dfd2122e4 Cr-Commit-Position: refs/heads/master@{#303104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
Created Revert of [Android] Support unfocusable container views.
6 years, 1 month ago (2014-11-06 22:37:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712433002/1
6 years, 1 month ago (2014-11-06 22:38:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 22:39:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1906fd177547e131f1320346df164a5dfd2122e4 Cr-Commit-Position: refs/heads/master@{#303104}
6 years, 1 month ago (2014-11-06 22:40:39 UTC) #4
Nicolas Zea
6 years, 1 month ago (2014-11-06 22:56:14 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/707043002/ by zea@chromium.org.

The reason for reverting is: Did not fix flake..

Powered by Google App Engine
This is Rietveld 408576698