Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 71243002: Support headless content_shell for linux/aura. (Closed)

Created:
7 years, 1 month ago by r.kasibhatla
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support headless content_shell for linux/aura. When running blink layout tests, we shouldn't create native windows. We should rather just create the virtual content window for render of content. Headless mode of content shell support is already present on other ports and needs to be added for aura. It is important in terms of performance (when running layout tests). BUG=316712 R=jochen TEST=None; no behavior change; Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236040

Patch Set 1 #

Patch Set 2 : Fix the crash seen with earlier patch in popup tests! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 6 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
r.kasibhatla
PTAL.
7 years, 1 month ago (2013-11-13 07:16:00 UTC) #1
jochen (gone - plz use gerrit)
can you verify that if you run a regular pixel test followed by a W3C-SVG ...
7 years, 1 month ago (2013-11-13 11:47:36 UTC) #2
r.kasibhatla
On 2013/11/13 11:47:36, jochen wrote: > can you verify that if you run a regular ...
7 years, 1 month ago (2013-11-13 13:18:45 UTC) #3
jochen (gone - plz use gerrit)
the initial sizes in your output look correct. We still don't have baselines for aura, ...
7 years, 1 month ago (2013-11-13 13:46:55 UTC) #4
r.kasibhatla
On 2013/11/13 13:46:55, jochen wrote: > the initial sizes in your output look correct. > ...
7 years, 1 month ago (2013-11-13 15:55:19 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-13 15:58:45 UTC) #6
r.kasibhatla
On 2013/11/13 15:58:45, jochen wrote: > lgtm Please wait!!! With the change, I have noticed ...
7 years, 1 month ago (2013-11-13 16:06:18 UTC) #7
Dirk Pranke
Yes, plugins appear broken w/ Linux Aura, and we need lots of new baselines. 850 ...
7 years, 1 month ago (2013-11-13 17:26:50 UTC) #8
r.kasibhatla
I noticed in the latest trunk, we have reverted back to gtk builds instead of ...
7 years, 1 month ago (2013-11-19 05:09:09 UTC) #9
Dirk Pranke
On 2013/11/19 05:09:09, r.kasibhatla wrote: > I noticed in the latest trunk, we have reverted ...
7 years, 1 month ago (2013-11-19 06:14:25 UTC) #10
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-19 13:43:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/71243002/130001
7 years, 1 month ago (2013-11-19 18:00:24 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 20:32:13 UTC) #13
Message was sent while issue was closed.
Change committed as 236040

Powered by Google App Engine
This is Rietveld 408576698