content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 71243002: Support headless content_shell for linux/aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 71243002: Support headless content_shell for linux/aura. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the crash seen with earlier patch in popup tests! Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index ee2a48a67643a3a39bec4092ee4e94f167bce357..8c3f4b45c756acc3997bdc03051bcd4fa726895b 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -513,7 +513,8 @@ void RenderWidgetHostViewAura::InitAsPopup(

window_->SetName("RenderWidgetHostViewAura");

aura::Window* root = popup_parent_host_view_->window_->GetRootWindow();

- aura::client::ParentWindowWithContext(window_, root, bounds_in_screen);

+ if (root)

+ aura::client::ParentWindowWithContext(window_, root, bounds_in_screen);

SetBounds(bounds_in_screen);

Show();

« no previous file with comments | « no previous file | content/shell/browser/shell.h » ('j') | no next file with comments »