Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issue 712333004: Create the document font using normal FontBuilder calls.

Created:
6 years, 1 month ago by andersr
Modified:
5 years, 10 months ago
Reviewers:
dglazkov
CC:
blink-reviews, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Create the document font using normal FontBuilder calls. FontBuilder::createFontForDocument presumably exists because FontBuilder used to be dependent on CSSValues and/or because it made an unnecessary amount of comparisons between FontDescriptions. This is no longer the case, so we don't need special code for the document font anymore. This also removes the need the arbitrary-FontDescription versions of some of the FontBuilder functions, and these have how been folded into their respective main functions. (setFamilyDescription, setSize, updateComputedSize). Also, rename Document::setupFontBuilder to Document::createFont. R=dglazkov@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Recreate patch on new master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -62 lines) Patch
M Source/core/css/resolver/FontBuilder.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/resolver/FontBuilder.cpp View 1 2 5 chunks +22 lines, -52 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
6 years, 1 month ago (2014-11-18 15:47:27 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698