Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 7123001: Merge 87553 - Fix issue with static ipconfig not creating dhcp ip configs properly. (Closed)

Created:
9 years, 6 months ago by Charlie Lee
Modified:
9 years, 6 months ago
Reviewers:
Charlie Lee
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 87553 - Fix issue with static ipconfig not creating dhcp ip configs properly. Only show static/dhcp selection for ethernet and wifi. BUG=chromium-os:569 TEST=None Review URL: http://codereview.chromium.org/7101013 TBR=chocobo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_detail.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/chromeos/internet_options.js View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Charlie Lee
9 years, 6 months ago (2011-06-07 00:18:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698