Fix issue with static ipconfig not creating dhcp ip configs properly.

Fix issue with static ipconfig not creating dhcp ip configs properly.
Only show static/dhcp selection for ethernet and wifi.
BUG=chromium-os:569
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87553

[Charlie Lee, 2011-06-01 22:32:03]

please take a quick look. thanks.

[stevenjb, 2011-06-01 22:53:51]

http://codereview.chromium.org/7101013/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7101013/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:3399:
chromeos::RemoveIPConfig(ipconfig_static);
Do we need to set ipconfig_static = NULL here so that we don't execute the if
(ipconfig_static) logic below?

[Charlie Lee, 2011-06-01 22:58:07]

Please take a look at the fix to not show ipconfig selection for non wifi and
non ethernet networks.

http://codereview.chromium.org/7101013/diff/1/chrome/browser/chromeos/cros/ne...
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/7101013/diff/1/chrome/browser/chromeos/cros/ne...
chrome/browser/chromeos/cros/network_library.cc:3399:
chromeos::RemoveIPConfig(ipconfig_static);
we no longer use ipconfig_static anymore in this method. the code you are
referring to is in the other if/else block.

On 2011/06/01 22:53:51, Steven Bennetts wrote:
> Do we need to set ipconfig_static = NULL here so that we don't execute the if
> (ipconfig_static) logic below?

[stevenjb, 2011-06-01 23:01:54]

Ah, OK, the diff formatting confused me.

LGTM

[stevenjb, 2011-06-01 23:12:37]

LGTM