Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 712293003: Add condition for checking AXExpanded on mac. (Closed)

Created:
6 years, 1 month ago by je_julie(Not used)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, shreeramk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add condition for checking AXExpanded on mac. The problem is that AXExpanded appears for all elements on mac. This patch adds condition to add AXExpanded with expanded state and collapsed state. BUG=98982 Committed: https://crrev.com/f3b521494222905622ef84d56c93e327ef35d8c9 Cr-Commit-Position: refs/heads/master@{#303799}

Patch Set 1 #

Patch Set 2 : Update test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 chunks +8 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria-expanded-expected-mac.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-haspopup-expected-mac.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
je_julie(Not used)
Hi Dominic, This patch adds condition for checking AXExpanded on mac. Previously it was added ...
6 years, 1 month ago (2014-11-11 10:50:59 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-12 06:20:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712293003/20001
6 years, 1 month ago (2014-11-12 06:21:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-12 07:37:59 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f3b521494222905622ef84d56c93e327ef35d8c9 Cr-Commit-Position: refs/heads/master@{#303799}
6 years, 1 month ago (2014-11-12 07:38:36 UTC) #7
faulkner.steve
On Wednesday, 12 November 2014 07:38:38 UTC, commi...@chromium.org wrote: > > Patchset 2 (id:??) landed ...
5 years, 10 months ago (2015-02-13 16:22:01 UTC) #8
dmazzoni
Thanks, Steve! I'm not seeing this behavior in Chrome 41 and higher so it sounds ...
5 years, 10 months ago (2015-02-13 17:35:57 UTC) #9
dmazzoni
Ah, yes - looks like (1) this broke with this patch on Oct 30: https://codereview.chromium.org/665843002 ...
5 years, 10 months ago (2015-02-13 17:39:22 UTC) #10
faulkner.steve
On 2015/02/13 17:39:22, dmazzoni wrote: > Ah, yes - looks like > (1) this broke ...
5 years, 10 months ago (2015-02-13 18:03:31 UTC) #11
je_julie(Not used)
5 years, 10 months ago (2015-02-15 14:41:02 UTC) #12
Message was sent while issue was closed.
On 2015/02/13 18:03:31, faulkner.steve wrote:
> On 2015/02/13 17:39:22, dmazzoni wrote:
> > Ah, yes - looks like
> > (1) this broke with this patch on Oct 30:
> > https://codereview.chromium.org/665843002
> > (2) then we branched for Chrome 40 on Nov 7
> > (3) then this change fixed it, on Nov 11th.
> > 
> > Annoying that this slipped through! I'll look into a patch to Chrome 40, but
> > either way Chrome 41 comes out in ~2 weeks.
> 
> Cool thanks for chasing it up!

Thanks, Dominic and Steve and sorry for the problem.
If it needs any further investigation, please let me know.

Powered by Google App Engine
This is Rietveld 408576698