Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 665843002: Change condition for adding AX_STATE_EXPANDED (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change condition for adding AX_STATE_EXPANDED This state should be decided according to aria-expanded attribute. BUG=98982 Committed: https://crrev.com/1f7fa9c53d0d3cc256ab9e50500ade447bd64c75 Cr-Commit-Position: refs/heads/master@{#302089}

Patch Set 1 #

Patch Set 2 : Update expeceted test Results #

Patch Set 3 : Handle AXExpanded and isCollapsed #

Patch Set 4 : Update code by adding new enum in blink #

Patch Set 5 : Remove AXExpanded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -25 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 4 2 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
A content/test/data/accessibility/aria-expanded.html View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-expanded-expected-android.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
A content/test/data/accessibility/aria-expanded-expected-mac.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-expanded-expected-win.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-haspopup.html View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-haspopup-expected-mac.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria-haspopup-expected-win.txt View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
je_julie(Not used)
Hi Dominic and David, This patch changes the condition for adding AX_STATE_EXPANDED. The related CL ...
6 years, 2 months ago (2014-10-20 12:58:50 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-20 16:34:34 UTC) #3
je_julie(Not used)
Hi Dominic, Mike and Davie, I updated the patch because we need to distinguish 'undefined' ...
6 years, 2 months ago (2014-10-24 07:44:44 UTC) #5
je_julie(Not used)
Sorry for the typos. On 2014/10/24 07:44:44, je_julie wrote: > Hi Dominic, Mike and David, ...
6 years, 2 months ago (2014-10-24 07:47:39 UTC) #6
dmazzoni
lgtm Fantastic, thanks!
6 years, 2 months ago (2014-10-24 07:54:54 UTC) #7
Mike West
On 2014/10/24 07:54:54, dmazzoni wrote: > lgtm > > Fantastic, thanks! content/shell (and the rest) ...
6 years, 2 months ago (2014-10-24 09:53:44 UTC) #8
je_julie(Not used)
Hi Dominic and Mike, I updated this patchset to handle expanded state for chromium according ...
6 years, 1 month ago (2014-10-30 04:01:10 UTC) #11
dmazzoni
Fantastic, this is definitely looking better. My only complaint is that you're defining AXExpanded in ...
6 years, 1 month ago (2014-10-30 05:35:31 UTC) #12
je_julie(Not used)
On 2014/10/30 05:35:31, dmazzoni wrote: > Fantastic, this is definitely looking better. > > My ...
6 years, 1 month ago (2014-10-30 10:33:56 UTC) #13
dmazzoni
lgtm
6 years, 1 month ago (2014-10-30 15:09:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/665843002/120001
6 years, 1 month ago (2014-10-30 15:10:11 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:120001)
6 years, 1 month ago (2014-10-30 16:09:51 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 16:10:34 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1f7fa9c53d0d3cc256ab9e50500ade447bd64c75
Cr-Commit-Position: refs/heads/master@{#302089}

Powered by Google App Engine
This is Rietveld 408576698