Issue 712173002: Remove StyleInvalidator machinery.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 712173002: Remove StyleInvalidator machinery. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Remove StyleInvalidator machinery. We don't support descendant selectors, so switch everything back to basic hash table lookups. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/52b039a27c78c9517516421402da195db536ba13

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -1114 lines)			Patch
M	sky/engine/core/core.gni	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/css/RuleFeature.h	View	3 chunks	+19 lines, -79 lines	0 comments	Download
M	sky/engine/core/css/RuleFeature.cpp	View	4 chunks	+33 lines, -304 lines	0 comments	Download
D	sky/engine/core/css/invalidation/DescendantInvalidationSet.h	View	1 chunk	+0 lines, -107 lines	0 comments	Download
D	sky/engine/core/css/invalidation/DescendantInvalidationSet.cpp	View	1 chunk	+0 lines, -226 lines	0 comments	Download
D	sky/engine/core/css/invalidation/DescendantInvalidationSetTest.cpp	View	1 chunk	+0 lines, -64 lines	0 comments	Download
D	sky/engine/core/css/invalidation/StyleInvalidator.h	View	1 chunk	+0 lines, -97 lines	0 comments	Download
D	sky/engine/core/css/invalidation/StyleInvalidator.cpp	View	1 chunk	+0 lines, -167 lines	0 comments	Download
M	sky/engine/core/css/resolver/StyleResolver.cpp	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	sky/engine/core/dom/Document.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	6 chunks	+1 line, -21 lines	0 comments	Download
M	sky/engine/core/dom/Element.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Node.h	View	3 chunks	+2 lines, -12 lines	0 comments	Download
M	sky/engine/core/dom/Node.cpp	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

esprehn

6 years, 1 month ago (2014-11-11 01:35:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
52b039a27c78c9517516421402da195db536ba13.