Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: sky/engine/core/dom/Node.h

Issue 712173002: Remove StyleInvalidator machinery. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Node.h
diff --git a/sky/engine/core/dom/Node.h b/sky/engine/core/dom/Node.h
index f569d596f7c1ca4db61fb6cacac1d345c9b55447..dc661ec7fca15af704eadf10daa9fecd56267d4b 100644
--- a/sky/engine/core/dom/Node.h
+++ b/sky/engine/core/dom/Node.h
@@ -288,14 +288,6 @@ public:
void clearChildNeedsDistributionRecalc() { clearFlag(ChildNeedsDistributionRecalcFlag); }
void markAncestorsWithChildNeedsDistributionRecalc();
- bool childNeedsStyleInvalidation() const { return getFlag(ChildNeedsStyleInvalidationFlag); }
- void setChildNeedsStyleInvalidation() { setFlag(ChildNeedsStyleInvalidationFlag); }
- void clearChildNeedsStyleInvalidation() { clearFlag(ChildNeedsStyleInvalidationFlag); }
- void markAncestorsWithChildNeedsStyleInvalidation();
- bool needsStyleInvalidation() const { return getFlag(NeedsStyleInvalidationFlag); }
- void clearNeedsStyleInvalidation() { clearFlag(NeedsStyleInvalidationFlag); }
- void setNeedsStyleInvalidation();
-
void recalcDistribution();
void setIsLink(bool f);
@@ -594,10 +586,8 @@ private:
// Flags related to recalcStyle.
- // FIXME(sky): Flags 12-14 are free.
+ // FIXME(sky): Flags 12-16 are free.
- ChildNeedsStyleInvalidationFlag = 1 << 15,
- NeedsStyleInvalidationFlag = 1 << 16,
ChildNeedsDistributionRecalcFlag = 1 << 17,
ChildNeedsStyleRecalcFlag = 1 << 18,
StyleChangeMask = 1 << nodeStyleChangeShift | 1 << (nodeStyleChangeShift + 1),
@@ -614,7 +604,7 @@ private:
DefaultNodeFlags = ChildNeedsStyleRecalcFlag | NeedsReattachStyleChange
};
- // 7 bits remaining.
+ // 9 bits remaining.
bool getFlag(NodeFlags mask) const { return m_nodeFlags & mask; }
void setFlag(bool f, NodeFlags mask) { m_nodeFlags = (m_nodeFlags & ~mask) | (-(int32_t)f & mask); }
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698