Make ReadableStream implementation up to date.

Make ReadableStream implementation up to date.

Make already-implemented functions up to date. Unimplemented features such
as piping and strategy are still unimplemented.

BUG=393911
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185181

[yhirano, 2014-11-10 11:31:23]

yhirano@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2014-11-11 12:43:33]

lgtm

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStream.cpp:74: return true;
FYI, there was a change about exception throwing from enqueue. Please fix later.
https://streams.spec.whatwg.org/#create-readable-stream-enqueue-function

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStreamTest.cpp (left):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStreamTest.cpp:542:
stream->wait(scriptState()).then(createCaptor(&onWaitFulfilled),
createCaptor(&onWaitRejected));
can't we keep this line?

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStreamTest.cpp:549:
EXPECT_TRUE(onWaitRejected.isNull());
and these

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStreamTest.cpp:555:
EXPECT_TRUE(onWaitRejected.isNull());
and these

[yhirano, 2014-11-12 04:20:29]

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStream.cpp:74: return true;
On 2014/11/11 12:43:32, tyoshino wrote:
> FYI, there was a change about exception throwing from enqueue. Please fix
later.
> https://streams.spec.whatwg.org/#create-readable-stream-enqueue-function

I see, but I don't want to throw an exception (unless the situation changes) and
it does no harm here, because actually enqueue is not called from JS. I added a
comment.

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStreamTest.cpp (left):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStreamTest.cpp:542:
stream->wait(scriptState()).then(createCaptor(&onWaitFulfilled),
createCaptor(&onWaitRejected));
On 2014/11/11 12:43:33, tyoshino wrote:
> can't we keep this line?

This is a test for "close when readable" case, and waitPromise is not related to
this test. I only want to check that close() don't reset the promise here.
Previously, close() reset waitPromise and resolved it with undefined, so I
checked that in this case.

[tyoshino (SeeGerritForStatus), 2014-11-12 04:27:16]

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStream.cpp:74: return true;
On 2014/11/12 04:20:29, yhirano wrote:
> On 2014/11/11 12:43:32, tyoshino wrote:
> > FYI, there was a change about exception throwing from enqueue. Please fix
> later.
> > https://streams.spec.whatwg.org/#create-readable-stream-enqueue-function
> 
> I see, but I don't want to throw an exception (unless the situation changes)
and
> it does no harm here, because actually enqueue is not called from JS. I added
a
> comment.

I see. OK.

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
File Source/core/streams/ReadableStreamTest.cpp (left):

https://codereview.chromium.org/712043002/diff/40001/Source/core/streams/Read...
Source/core/streams/ReadableStreamTest.cpp:542:
stream->wait(scriptState()).then(createCaptor(&onWaitFulfilled),
createCaptor(&onWaitRejected));
On 2014/11/12 04:20:29, yhirano wrote:
> On 2014/11/11 12:43:33, tyoshino wrote:
> > can't we keep this line?
> 
> This is a test for "close when readable" case, and waitPromise is not related
to
> this test. I only want to check that close() don't reset the promise here.
> Previously, close() reset waitPromise and resolved it with undefined, so I
> checked that in this case.

OK

[yhirano, 2014-11-12 04:37:01]

yhirano@chromium.org changed reviewers:
+ tkent@chromium.org

[yhirano, 2014-11-12 04:37:11]

+tkent for OWNER review.

[tkent, 2014-11-12 05:07:05]

rs lgtm

[yhirano, 2014-11-12 05:30:32]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-11-12 05:30:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712043002/60001

[commit-bot: I haz the power, 2014-11-12 06:18:01]

Committed patchset #4 (id:60001) as 185181