Make ReadableStream implementation up to date.

Source/core/streams/ReadableStream.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/streams/ReadableStream.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/streams/UnderlyingSource.h"
 
 namespace blink {
 
+namespace {
+
+class ConstUndefined : public ScriptFunction {
+public:
+    static v8::Handle<v8::Function> create(ScriptState* scriptState)
+    {
+        return (new ConstUndefined(scriptState))->bindToV8Function();
+    }
+
+private:
+    explicit ConstUndefined(ScriptState* scriptState) : ScriptFunction(scriptState) { }
+    ScriptValue call(ScriptValue value) override
+    {
+        return ScriptValue(scriptState(), v8::Undefined(scriptState()->isolate()));
+    }
+};
+
+} // namespace
+
 ReadableStream::ReadableStream(ExecutionContext* executionContext, UnderlyingSource* source)
     : m_source(source)
     , m_isStarted(false)
     , m_isDraining(false)
     , m_isPulling(false)
-    , m_isSchedulingPull(false)
     , m_state(Waiting)
     , m_wait(new WaitPromise(executionContext, this, WaitPromise::Ready))
     , m_closed(new ClosedPromise(executionContext, this, ClosedPromise::Closed))
 {
 }
 
 ReadableStream::~ReadableStream()
 {
 }
 
@@ skipping 11 matching lines @@
     }
     ASSERT(false);
     return String();
 }
 
 bool ReadableStream::enqueuePreliminaryCheck(size_t chunkSize)
 {
     if (m_state == Errored || m_state == Closed || m_isDraining)
         return false;
 
-    // FIXME: Query strategy.
     return true;

[tyoshino (SeeGerritForStatus), 2014/11/11 12:43:32]

FYI, there was a change about exception throwing from enqueue. Please fix later.
https://streams.spec.whatwg.org/#create-readable-stream-enqueue-function

[yhirano, 2014/11/12 04:20:29]

I see, but I don't want to throw an exception (unless the situation changes) and
it does no harm here, because actually enqueue is not called from JS. I added a
comment.

[tyoshino (SeeGerritForStatus), 2014/11/12 04:27:16]

I see. OK.

 }
 
 bool ReadableStream::enqueuePostAction(size_t totalQueueSize)
 {
     m_isPulling = false;
 
-    // FIXME: Set needsMore correctly.
-    bool needsMore = true;
+    // FIXME: Set |shouldApplyBackpressure| correctly.
+    bool shouldApplyBackpressure = false;
 
     if (m_state == Waiting) {
         m_state = Readable;
         m_wait->resolve(V8UndefinedType());
     }
 
-    return needsMore;
+    return !shouldApplyBackpressure;
 }
 
 void ReadableStream::close()
 {
     if (m_state == Waiting) {
         m_wait->resolve(V8UndefinedType());
         m_closed->resolve(V8UndefinedType());
         m_state = Closed;
     } else if (m_state == Readable) {
         m_isDraining = true;
@@ skipping 15 matching lines @@
         return;
     }
 }
 
 void ReadableStream::readPostAction()
 {
     ASSERT(m_state == Readable);
     if (isQueueEmpty()) {
         if (m_isDraining) {
             m_state = Closed;
-            m_wait->reset();
-            m_wait->resolve(V8UndefinedType());
             m_closed->resolve(V8UndefinedType());
         } else {
             m_state = Waiting;
             m_wait->reset();
-            callOrSchedulePull();
         }
     }
+    callPullIfNeeded();
 }
 
 ScriptPromise ReadableStream::wait(ScriptState* scriptState)
 {
-    if (m_state == Waiting)
-        callOrSchedulePull();
     return m_wait->promise(scriptState->world());
 }
 
 ScriptPromise ReadableStream::cancel(ScriptState* scriptState, ScriptValue reason)
 {
-    if (m_state == Errored) {
-        RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
-        ScriptPromise promise = resolver->promise();
-        resolver->reject(m_exception);
-        return promise;
-    }
     if (m_state == Closed)
         return ScriptPromise::cast(scriptState, v8::Undefined(scriptState->isolate()));
+    if (m_state == Errored)
+        return ScriptPromise::rejectWithDOMException(scriptState, m_exception);
 
-    if (m_state == Waiting) {
+    ASSERT(m_state == Readable || m_state == Waiting);
+    if (m_state == Waiting)
         m_wait->resolve(V8UndefinedType());
-    } else {
-        ASSERT(m_state == Readable);
-        m_wait->reset();
-        m_wait->resolve(V8UndefinedType());
-    }
-
     clearQueue();
     m_state = Closed;
     m_closed->resolve(V8UndefinedType());
-    return m_source->cancelSource(scriptState, reason);
+    return m_source->cancelSource(scriptState, reason).then(ConstUndefined::create(scriptState));
 }
 
 ScriptPromise ReadableStream::closed(ScriptState* scriptState)
 {
     return m_closed->promise(scriptState->world());
 }
 
 void ReadableStream::error(PassRefPtrWillBeRawPtr<DOMException> exception)
 {
-    if (m_state == Readable) {
-        clearQueue();
-        m_wait->reset();
-    }
-
-    if (m_state == Waiting || m_state == Readable) {
+    switch (m_state) {
+    case Waiting:
         m_state = Errored;
         m_exception = exception;
-        if (m_wait->state() == m_wait->Pending)
-            m_wait->reject(m_exception);
+        m_wait->reject(m_exception);
         m_closed->reject(m_exception);
+        break;
+    case Readable:
+        clearQueue();
+        m_state = Errored;
+        m_exception = exception;
+        m_wait->reset();
+        m_wait->reject(m_exception);
+        m_closed->reject(m_exception);
+        break;
+    default:
+        break;
     }
 }
 
 void ReadableStream::didSourceStart()
 {
     m_isStarted = true;
-    if (m_isSchedulingPull)
-        m_source->pullSource();
+    callPullIfNeeded();
 }
 
-void ReadableStream::callOrSchedulePull()
+void ReadableStream::callPullIfNeeded()
 {
-    if (m_isPulling)
+    if (m_isPulling || m_isDraining || !m_isStarted || m_state == Closed || m_state == Errored)
+        return;
+    // FIXME: Set shouldApplyBackpressure correctly.
+    bool shouldApplyBackpressure = false;
+    if (shouldApplyBackpressure)
         return;
     m_isPulling = true;
-    if (m_isStarted)
-        m_source->pullSource();
-    else
-        m_isSchedulingPull = true;
+    m_source->pullSource();
 }
 
 void ReadableStream::trace(Visitor* visitor)
 {
     visitor->trace(m_source);
     visitor->trace(m_wait);
     visitor->trace(m_closed);
     visitor->trace(m_exception);
 }
 
 } // namespace blink